Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an new feature "ignore URL patterns". #16

Closed
yzwdroid opened this issue Oct 15, 2020 · 6 comments
Closed

add an new feature "ignore URL patterns". #16

yzwdroid opened this issue Oct 15, 2020 · 6 comments
Assignees

Comments

@yzwdroid
Copy link
Contributor

Hi Matthew, as described in lab 4 can I add an "ignore URL patterns" feature into your repo.

  • about the ignored file.
    the file is a simple text file where each line is either a URL (line starts with http:// or https://) or an optional comment (line starts with #, and can be ignored).
@MSTEWARDSON
Copy link
Owner

Yes sounds good, go ahead. I assigned you to this issue.

@yzwdroid
Copy link
Contributor Author

yzwdroid commented Oct 17, 2020

I have pushed my work to issue-16 branch. Could you please check it? Any problem, let me known.

For testing, run go run main.go test.txt -i, the default ignore file is ignore.txt

@MSTEWARDSON
Copy link
Owner

Alright thanks.

@MSTEWARDSON
Copy link
Owner

So I have a few suggestions for fully implementing this feature.

  1. Add a ignore help message to the helpful information output.
  2. Update the ReadMe to show how to use this new feature.

Other then that the code looks good. I like the default ignore file option you added. Good job!

@yzwdroid
Copy link
Contributor Author

I have added a new commit, please check it out.

@MSTEWARDSON
Copy link
Owner

Perfect, thanks! I have now merged your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants