Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Win11 Insider Preview 22489.1000 #31

Closed
korpa opened this issue Nov 4, 2021 · 14 comments
Closed

Not working on Win11 Insider Preview 22489.1000 #31

korpa opened this issue Nov 4, 2021 · 14 comments

Comments

@korpa
Copy link

korpa commented Nov 4, 2021

Hi,

I was really happy to find this tool, as VDesk was not updated to Win11 yet: eksime/VDesk#92

On my Windows 11 Pro 21H2 (OS build: 22000.258) this runs really great. But sadly on my test machine with Win11 Insider Preview (OS build 22489.1000) it doesn't work.

I really would like to fix this and create an Pull Request, but as I'm a complete newbie to C# and windows development I have no idea were to start. I understood that MS is changing the API for virtual desk a couple of times in the last windows versions. Therefore I would start there. Could you give me a hint where to start researching about these API changes.

Many thanks

@MScholtes
Copy link
Owner

Hello @korpa,

I'm sorry, but I can't provide support for the Insider versions of Windows because the API can change all the time. The introduction of Windows 11 was an exception here, although the Dev Channel was never taken into account here either.

Unfortunately, I can't offer you any programming support either. To work on this project, you need C#, COM and deep OS knowledge.

Greetings

Markus

@korpa
Copy link
Author

korpa commented Nov 5, 2021

Hi Markus,

sorry that I was not clear. I didn't mean that you should provide programming support for me. I do programming for over 20 years. So to learn C# should not be the problem. My question is where I can find the API documentation for virtual desktops.

@MScholtes
Copy link
Owner

Hello @korpa,

there is no misunderstanding: there is no documentation!
Microsoft does not support direct addressing of the API for virtual desktops, nor does Microsoft document it, which is perhaps why the API is changed so frequently.

You have to find out everything yourself.

Greetings

Markus

@korpa
Copy link
Author

korpa commented Nov 5, 2021

Hi Markus,

understood. That's really disappointing. Then I have to decide for my self if I go done the rabbit hole 😆

Nevertheless, thanks for your work so far on VirtualDesktops. At least I was able to develop a graphical desktop switcher for Win11 based on your work.
image

@MScholtes
Copy link
Owner

But I have a hint (not tested):

It might work when you insert the following line

IObjectArray GetAllCurrentDesktops();

before line 170 of VirtualDesktop11.cs (between the line with the declaration of "GetCurrentDesktop" and the line with "GetDesktops") and then compile again.

Greetings

Markus

@korpa
Copy link
Author

korpa commented Nov 5, 2021

Cool. Will try this. Furthermore I wonder if #29 will help. Will try this as well.

@SweetMNM
Copy link

@korpa Hi! Did you get it to work? I am on insider build 22494, and it does not work (which is to be expected).

@MScholtes
Copy link
Owner

Hello @korpa, hello world,

I have no access to Dev Channel versions of Windows 11 Insider, so I cannot test any changes for versions 22489 or22494.

If someone could test my suggest change from above ("...insert the following line IObjectArray GetAllCurrentDesktops();...") I could build a temporary version with support on success.

Greetings

Markus

@SweetMNM
Copy link

Hello @korpa, hello world,

I have no access to Dev Channel versions of Windows 11 Insider, so I cannot test any changes for versions 22489 or22494.

If someone could test my suggest change from above ("...insert the following line IObjectArray GetAllCurrentDesktops();...") I could build a temporary version with support on success.

Greetings

Markus

Hi @MScholtes

That worked like magic!
Can't confirm every single functionality of VirtualDesktop works since I haven't tested it all but everything I am interested in (creating, removing desktops. Moving windows etc...) worked perfectly.

Thanks a lot for this awesome project! It's going to be super useful for me :)

Do you want me to create a PR with VirtualDesktop11Insider.cs?

@MScholtes
Copy link
Owner

Hello @korpa,

thank you for testing. Since the changes are so few, there is no need for a pull request. I will update an new version in the next minutes.

Greetings

Markus

@MScholtes
Copy link
Owner

New version with VirtualDesktop11Insider.cs released

@NyaMisty
Copy link
Contributor

So why you are turning down my PR?
Microsoft haven't change anything since 22449.

@MScholtes
Copy link
Owner

Hello @NyaMisty,

I only decided to publish another version for the Dev Channel because I saw that the need was greater than expected and when I saw that the difference was only one line. If there are more differences, I will probably remove this version again.

I am very grateful to you for identifying the names, but the pull request is for an older version of VirtualDesktop.

I decided to

Greetings

Markus

@MScholtes
Copy link
Owner

Closed since issue is solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants