Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login through annotator.freesound.org is not possible #173

Closed
xavierfav opened this issue Mar 21, 2019 · 2 comments
Closed

Login through annotator.freesound.org is not possible #173

xavierfav opened this issue Mar 21, 2019 · 2 comments

Comments

@xavierfav
Copy link
Contributor

When trying to login from the new domain name (annotator.freesound.org), a AuthStateMissing exception is raised (e.g. check this error in sentry).

The OAuth2 callback URL of the Freesound API credentials we use is redirecting to the old domain name (datasets.freesound.org), which causes this problem (the session is not shared across the different domain names).

To fix this, we could maybe:

  • share the same cookie session with the two domains we use (probably a CrossDomainSessionMiddleware similar to what is proposed here)
  • have a redirection from datasets.freesound.org to annotator.freesound.org so that we do not serve the application to two domain names (we should also update the OAuth2 callback URL of the Freesound API credentials to point to the new domain)
@alastair
Copy link
Member

The easiest way to fix this is to finalise the redirect. We shouldn't have to do anything with cookies.

@xavierfav
Copy link
Contributor Author

Great.
The credentials have been updated and will take effect on the next deploy.
Let's coordinate and finalist the redirect together with the deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants