Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with name resolver #58

Closed
fra87 opened this issue Jul 4, 2022 · 6 comments
Closed

Issue with name resolver #58

fra87 opened this issue Jul 4, 2022 · 6 comments
Labels
wontfix This will not be worked on

Comments

@fra87
Copy link

fra87 commented Jul 4, 2022

Hello

Due to issues with the ISP, sometimes the name of servers cannot be resolved.

This however permanently blocks the extension, since from that moment the extension (I assume) doesn't try again to contact the server.

Here is the log entry with that problem.
pyworxcloud - log.txt

The issue happened on 1st July, and until now (3 days) it has not recovered. No additional log entries are present in the log list in Home Assistant, so I assume the script crashed.

I expect the extension to continue retrying and, when the DNS come back online, resume proper operations

@MTrab
Copy link
Owner

MTrab commented Jul 4, 2022

This is unfortunately completely out of my hands. That's something you have to take with your ISP.
DNS names resolves just as they should using both my ISP DNS servers, Google DNS and CloudFlare DNS.

@MTrab MTrab closed this as completed Jul 4, 2022
@MTrab MTrab added the wontfix This will not be worked on label Jul 4, 2022
@fra87
Copy link
Author

fra87 commented Jul 4, 2022

Maybe I was not clear enough in the first message.

Of course the ISP DNS resolution is out of the extensions hands, but I expect that when the connection comes back then the extension resumes working. In this case, on the other hand, the connection came back 3 days ago, but the extension did not work.

I assume it is because the exceptions in the logs are not handled correctly, and so the pyworxcloud extension stops working

@MTrab
Copy link
Owner

MTrab commented Jul 4, 2022

As it says - max retries exceeded. When that happens, no more retries will be tried until you restart your Home Assistant

@fra87
Copy link
Author

fra87 commented Jul 4, 2022

Well, that's the point... I think that an automatic system shall not need to be restarted in case something happens, but it shall be able to automatically recover.

So in this case I think that after some time it shall try again, otherwise it becomes locked in this state forever

@MTrab
Copy link
Owner

MTrab commented Jul 4, 2022

You could have a point in that. I'll reopen the issue and do some investigation into if it's possible to somehow reset/reload/retry after a given time.

@MTrab MTrab reopened this Jul 4, 2022
@MTrab MTrab added enhancement New feature or request under investigation This issue is being investigated, to determine the cause low priority Low priority issue/request and removed wontfix This will not be worked on labels Jul 4, 2022
@MTrab
Copy link
Owner

MTrab commented Oct 24, 2022

I'll close this, as everything is up for a rewrite as a result of recently gaining access to the full Positec repository with the correct documentation of the API and description of how to use the API the correct way.

@MTrab MTrab closed this as completed Oct 24, 2022
@MTrab MTrab added wontfix This will not be worked on and removed enhancement New feature or request under investigation This issue is being investigated, to determine the cause low priority Low priority issue/request labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants