Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't seem to make edits #81

Closed
Jarry1250 opened this issue Jul 20, 2014 · 8 comments
Closed

Can't seem to make edits #81

Jarry1250 opened this issue Jul 20, 2014 · 8 comments
Labels

Comments

@Jarry1250
Copy link
Contributor

Assert fails, and turning off assertion checks doesn't seem to help. Definitely some sort of regression/breaking change since 2908db4 (5 March).

@cyberpower678
Copy link
Contributor

You're right about the issue, but it hasn't been occurring until your commit. I'm not pointing fingers however. With limited resources at hand right now, I can't diagnose the issue right now. I'll have to look at in a week.

@cyberpower678
Copy link
Contributor

I checked the adminstats logs and it seems it last ran successfully on the 18th. Ever since, it started getting assert failures.

@cyberpower678
Copy link
Contributor

I looked at your commit and there's nothing there that stands out to me. So I'll have to start up the debugger next week.

@Jarry1250
Copy link
Contributor Author

I think the issue is the incidental change I made where I corrected the line (approx line #680):

$data['error']['code'] == 'assertuserfailed';

to

$data['error']['code'] = 'assertuserfailed';

(I will test this theory.)

@cyberpower678
Copy link
Contributor

I don't know. I don't see it.

@Jarry1250
Copy link
Contributor Author

Oh no, this is my fault I think, in 9714ca3 I change a "else break;" (which is an illegal syntax, since we're not in a loop) to "else return true;", when really if you want to cut execution of the function short you need "else return $data;".

@Jarry1250
Copy link
Contributor Author

Oh, actually, the statement should just be moved inside the loop. I wonder how it got pushed out (probably by me).

@Jarry1250
Copy link
Contributor Author

Fix now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants