Magicka Mastery by MageKing17 doens't work

[RandomPal]

Breif discussion here: https://www.reddit.com/r/Morrowind/comments/9g99sr/magicka_mastery_broken_with_the_lasted_mwse/

[NullCascade]

Weird, are we talking about the same mod? There might be some confusion since more than one mod has a similar name. This one is a 2017 mod, and it states in the description:

''This mod requires MWSE 0.9.5-alpha.20151016. Versions as early as 0.9.5-alpha.20150707 will possibly work, but there's no real reason not to use the latest.''

I can't give super precise information about what build I was using, but I tried to always stay up to date. Than I took a break from MW for some months, and when I came back I discovered the new amazing version of MWSE and all the crazy mods that are coming out. I rolled a new character and I sadly discovered that Magicka Mastery was broken. This is the best I can do, I'm willing to do some testing if it can be of any help, I know how to use the CS and the various tools, but unfortunately I know nothing about scripting.

And thank you for the new MWSE version :)

I'm not completely sure of it, I'm going off 2nd hand information. If you could test the different versions and let me know if it broke after v0.9.5-alpha.20171111, we can determine where and the priority of the break.

From what G7 said, the break was from v0.9.5-alpha.20171111's change to xGetMagic, which allows a reference. This happened in the old branch.

@Greatness7 : Do you think it'd be safe to change xGetMagic to default to the player if no other reference is provided would fix backwards compatibility while working with any new mods? On that line, do you know why Merzaphor made this change? Do any mods take advantage of xGetMagic with a specified reference?

@RandomPal : What you could do to help is test Magicka Mastering in the following versions:

1. v0.9.5-alpha.20171006: This should be the last working version, if we are right.
2. v0.9.5-alpha.20171111: This is where we think it broke.
3. v2.0+: This is supposedly not working.

This would help us confirm that Greatness7 is correct about the cause of the break, and fix the issue.

[RandomPal]

@NullCascade
Ok, tested and double-checked.

1. MWSE v0.9.5-alpha.20171006: works
2. MWSE v0.9.5-alpha.20171111: doesn't work
3. 2+: I'm using the more updated version (latest update this morning) and it doesn't work

[NullCascade]

@RandomPal Thanks for testing. This confirms that G7 is right about the issue. We'll brainstorm on how to deal with it. Unfortunately mods are making use of the change, so we can't undo it.

[RandomPal]

@NullCascade Glad I could help. I'll stay tuned!

[Greatness7]

Breif discussion here: https://www.reddit.com/r/Morrowind/comments/9g99sr/magicka_mastery_broken_with_the_lasted_mwse/

Here's a fixed version of the original ESP:
MagickaMastery (halved progression).esp

Or alternatively, a lua port of the mod:
magickaMasteryLua

The lua versions should be a bit more efficient and also work for NPCs rather than just the player. You'll need to update your MWSE again as it uses some new features. Just be sure not to use both versions together.

[RandomPal]

@Greatness7 I did a quick testing and both versions work great. Having the lua version also working on NPCs is a very nice addition.
You should really get in touch with mageking17 and release the mod.
Thanks guys!

[NullCascade]

Posted this on his Nexus page. I pinged MageKing17 on his Nexus page about the fixed ESP, and the cause for the issue.

For now, I'm flagging this as won't fix, and hope that MageKing17 updates his mod with G7's changes. If this continues to be an issue in the future we can reevaluate.

[IllyaMoskvin]

I applied @Greatness7's fix to the non-"halved progression" ESP:

MagickaMastery (fixed).esp

For anyone new to Morrowind modding (like me), here's what's changed in the fixed version:

$ diff "MagickaMastery (halved progression).txt" "MagickaMastery (halved progression)(fixed).txt"
191c191,193
<   setx type id to xGetMagic
---
>   long ref
>   setx ref to xGetRef "player"
>   setx type id to ref->xGetMagic

...and here's what's different in the "halved progression" version:

$ diff "MagickaMastery.txt" "MagickaMastery (halved progression).txt"
251,252c251,252
< ;this makes a 5-point spell give the same progression as successfully casting a spell in vanilla Morrowind
< set fcost to (fcost / 5.0)
---
> ;this makes a 10-point spell give the same progression as successfully casting a spell in vanilla Morrowind
> set fcost to (fcost / 10.0)
254c254
< ;if the spell failed, divide by 5 again
---
> ;if the spell failed, divide by 10 again
257c257
<     set fcost to (fcost / 5.0)
---
>     set fcost to (fcost / 10.0)

I wish there was a way to convert ESP files to plaintext and back so they could be version managed.

@NullCascade Thank you for linking to this issue on both the Reddit thread and the Nexus mod page.

[MageKing17]

Hey guys; I was having some computer problems, so I only just saw the link to this issue. That Lua version is really cool; avoids a lot of hackish workarounds. @Greatness7, @NullCascade, may I use that as the basis for the next update? It's a really quite elegant upgrade, assuming it works as it seems to from reading the code.

[Greatness7]

Hey guys; I was having some computer problems, so I only just saw the link to this issue. That Lua version is really cool; avoids a lot of hackish workarounds. @Greatness7, @NullCascade, may I use that as the basis for the next update? It's a really quite elegant upgrade, assuming it works as it seems to from reading the code.

Sure, feel free to use it how ever you wish!

One thing to note: The majority of that lua code was spent updating the GUI. This is no longer needed as we have functions which handle that automatically when modifying a statistic (tes3.setStatistic).

Here's an updated version using said function: https://www.dropbox.com/s/ubq4p1xjrgj1seu/magickaMastery.zip?dl=0