Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DApps image caching #185

Open
SanghamitraBhowmick1993 opened this issue Apr 9, 2024 · 10 comments
Open

DApps image caching #185

SanghamitraBhowmick1993 opened this issue Apr 9, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@SanghamitraBhowmick1993
Copy link
Contributor

https://www.notion.so/wannsee-roadmap/DApps-image-caching-e3da5e6d125e47d8a1bf6fdb1e68cf1e

@SanghamitraBhowmick1993 SanghamitraBhowmick1993 added the bug Something isn't working label Apr 9, 2024
@reasje reasje added enhancement New feature or request and removed bug Something isn't working labels Apr 10, 2024
@reasje
Copy link
Contributor

reasje commented Apr 10, 2024

I want to include the json files of data which are (Tokens list & DApps) as sub module to AXS repo, Which will help getting updates instantly.
Then I can use their json inside app as assets whenever the Github is not responding for a particular use.

@reasje
Copy link
Contributor

reasje commented Apr 12, 2024

I have been able to initialize dapp store as submodule to Shared Repo and also use It's content to load data initially If anyhing goes wrong with getting data from Github.
I will be debuging It and once everything is fine I will move to token list local data.
Other data needs to be made local:
IPFS - Tweets

@reasje
Copy link
Contributor

reasje commented Apr 16, 2024

Token list local data has been initialized and works fine
I am moving to work on IPFS - Tweets

@reasje
Copy link
Contributor

reasje commented Apr 16, 2024

Some improvements are done down the road in order to imprv project structure:

  1. Separating Config from Utils
  2. Adding more helpers to reduce code in Config & Utils
  3. Some imports are updated systematically in order to reduce the boilerplate imports and duplications

@reasje
Copy link
Contributor

reasje commented Apr 16, 2024

Flutter analyzer is terminated, This prevents me from developing, This happened before but this time It doesn't work at all, I am checking for solution.

@reasje
Copy link
Contributor

reasje commented Apr 16, 2024

I was abel to solve the issue, Not sure what exactly was the fix, Because changes effecetd after sometime:

  1. Github guidence
  2. Changing some imports in contracts, The file that was mentioned to be missing analyzing

@reasje
Copy link
Contributor

reasje commented Apr 16, 2024

I have finished IPFS & tweets local data impl, I will start debugging.

@reasje
Copy link
Contributor

reasje commented Apr 18, 2024

@SanghamitraBhowmick1993
Debugging is finished, I have merged the changes to pre_main_qa.
For testing purpose :
If Github works fine in your region plz turn off your internet and open application,
YOu should be able to see : DApps with their images - Tokens list with their images - tweets card loading (Since loading from Tweeter needs connection) - IPFS gateway won't show in chain configuration settings because we need to test every ipfs gateway (which requires connection) in order to choose one.

@SanghamitraBhowmick1993
Copy link
Contributor Author

Tweets does not load w/o connection, but the dapp with their images/token list loads and working as expected. Could we move this and the permission exception changes to main @reasje so that we can raise a new playstore request as confirmed/aligned with @sheenhx

@reasje
Copy link
Contributor

reasje commented Apr 19, 2024

@SanghamitraBhowmick1993 Thanks for detailed information, If you see tweets cards without internet then It mean It's loaded from local, If the tweets are not showing It's expected because the connection is required to get tweets.
I have just merged to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants