Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling for file uploads #490

Open
fosterfarrell9 opened this issue May 3, 2023 · 2 comments
Open

Better error handling for file uploads #490

fosterfarrell9 opened this issue May 3, 2023 · 2 comments

Comments

@fosterfarrell9
Copy link
Collaborator

Currently, we have

client_max_body_size 4G;

in our config in docker/nginx.tmpl. A user tried to upload a 6GB video which conseqently failed. While I am not overly enthusiastic to rasing this to, say 8 GB, for resource reasons, maybe we should raise. Of course, I would alway encourage users to user better compression instead. Also, we might stop uploads of bigger files immediately with an error-message (as is done in the case of homework uploads). In the case above, the error message only came after the limit was reached during uploading.

@Splines
Copy link
Member

Splines commented May 3, 2023

These are really big files. If we allow a limit of 8GB, our SSDs will fill up pretty quickly for sure. Instead, we should implement a better error message in the frontend when users try to upload such a big file. Instead, they should compress their videos on their own before uploading. (Maybe in the future, we can even implement a compression service with ffmpeg or the like on our side, but that's a bigger todo I guess).

@fosterfarrell9 fosterfarrell9 changed the title Raise nginx upload limit Better error handling for file uploads May 4, 2023
@fosterfarrell9
Copy link
Collaborator Author

I agree (and the corresponding user could compress his file to 1.4GB which worked fine). I changed the title of the issue in the direction that it would still be good to produce an error message immediately when too large files are uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants