Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tooltips in MaRDI Query Service #536

Closed
4 tasks done
Daniel-Mietchen opened this issue Jun 3, 2024 · 10 comments
Closed
4 tasks done

Enable tooltips in MaRDI Query Service #536

Daniel-Mietchen opened this issue Jun 3, 2024 · 10 comments
Assignees

Comments

@Daniel-Mietchen
Copy link

New feature description in words:

When hovering over Wikibase identifiers in other instances, the user is given a tooltip displaying the corresponding label, e.g. as shown here:
image

TODOS:

Considered Alternatives:

  • The alternative would be to keep the status quo, which makes it hard to work with our endpoint.

Checklist for this issue:

  • Participants in discussion have been invited as assignees
  • All fields of the issue have been filled
  • Example fields have been removed
  • The main MaRDI project has been assigned to this issue
@physikerwelt
Copy link
Member

It seems to be blocked due to wrong CORS headers.

Quellübergreifende (Cross-Origin) Anfrage blockiert: Die Gleiche-Quelle-Regel verbietet das Lesen der externen Ressource auf https://portal.mardi4nfdi.de/w/api.php?origin=*&action=wbsearchentities&format=json&limit=50&continue=0&language=de&uselang=de&search=P31&type=property. (Grund: CORS-Kopfzeile 'Access-Control-Allow-Origin' fehlt). Statuscode: 200.

@physikerwelt
Copy link
Member

A quick workaround is to install (and enable https://addons.mozilla.org/en-US/firefox/addon/cors-everywhere/ ) At least this works for me.

@eloiferrer can you maybe look for a general solution?

@eloiferrer
Copy link
Member

I think this is a problem with our docker configuration. At the beginning of mardi, I spent already some time trying to fix it but did not succeed. I will have a look again. Just for reference, the issue was also described here:
#35
https://phabricator.wikimedia.org/T299067

@physikerwelt
Copy link
Member

Sorry, I wanted to reference this in a PR but not to close it. I am no deploying to staging for testing

@physikerwelt
Copy link
Member

Now, it works on staging. I'll try to deploy it to production.

@physikerwelt physikerwelt self-assigned this Jun 3, 2024
@physikerwelt
Copy link
Member

works now

@Daniel-Mietchen
Copy link
Author

@physikerwelt The problem has returned a few days ago - not sure what the trigger was.

@eloiferrer
Copy link
Member

Not sure what is going on, just wanted to note that it works in staging https://query.staging.mardi4nfdi.org/ which in principle uses the same exact configuration

@physikerwelt
Copy link
Member

In production, I see a 502 for https://query.portal.mardi4nfdi.de/proxy/wikibase/w/api.php?origin=*&action=query&meta=siteinfo&format=json&siprop=languages On staging, I see no examples (which were there before). I always used the cat example for testing.

@eloiferrer
Copy link
Member

I fixed this a couple weeks ago but I was waiting for a new deployment to see if it would break. Since it is still working after the deployment from yesterday I consider this tentatively solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants