Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying MaaMacGUI i18n translations #8770

Open
2 tasks done
RieLCho opened this issue Apr 3, 2024 · 1 comment
Open
2 tasks done

Applying MaaMacGUI i18n translations #8770

RieLCho opened this issue Apr 3, 2024 · 1 comment
Labels
client: MacGui Issue about MaaMacGui client: WpfGui Issue about MaaWpfGui enhancement New feature or request

Comments

@RieLCho
Copy link

RieLCho commented Apr 3, 2024

Before raising the issue...

  • I filled in a short, clear title so that developers could quickly identify the general problem when going through the issue list. Instead of "Some suggestions", "Stuck", etc.
  • I'm probably sure this is a new feature/suggestion and not a bug encountered (please attach logs if you're not sure)

The problems you have encountered?

First of all, thanks for contributing macOS client. I'm using this client very well, but most of foreign users would might need a i18n translations.

Any good ideas?

스크린샷 2024-04-03 오후 1 10 51

I guess we should remove those hardcoded strings and use NSLocalizedString

Additional

No response

@RieLCho RieLCho added the enhancement New feature or request label Apr 3, 2024
@github-actions github-actions bot added the client: MacGui Issue about MaaMacGui label Apr 3, 2024
@ABA2396
Copy link
Member

ABA2396 commented Apr 3, 2024

cc @hguandl

@github-actions github-actions bot added the client: WpfGui Issue about MaaWpfGui label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client: MacGui Issue about MaaMacGui client: WpfGui Issue about MaaWpfGui enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants