New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to undefined method PHPExcel_Reader_CSV::setLineEnding() #417
Comments
Just had this error this morning deploying as well! PHP Fatal error: Call to method PHPExcel_Reader_CSV::setLineEnding() in /home/rof/src/github.com/***/***/vendor/maatwebsite/excel/src/Maatwebsite/Excel/Readers/LaravelExcelReader.php on line 1097 Is it saying undefined? Because mine seems to have 2 spaces as if a word is supposed to be there... This is for 1.3 |
The 1.8.1 release of PHPExcel last night removed the getLineEnding() and setLineEnding() methods for the CSV file Reader because they did nothing more than get or set a property that was never actually used anywhere in the code. |
So we need to lock this project to 1.8.0? |
Thanks guys! |
Will this reflect the 1.3 branch BTW? |
That's what I'm using, not sure how it affects the 2.0 branch |
Ah right OK cool |
Problem will be the same in both branches. |
I have just done a PR to remove the references to lineEnding for the CSV Reader for 2.0 |
And one for 1.3 as well |
Looks like there were a few references that were missed in 2.0. I went ahead and sent a pull request. |
Related to this version of PHPExcel, this error comes up as well when running the CSV importer. [Symfony\Component\Debug\Exception\FatalErrorException] I temporarily commented out the setLineEnding in PHPExcel until Laravel-Excel's composer is fixed to 1.8.0... but then see there are more issues. |
re. PHPExcel_Worksheet_CellIterator::adjustForExistingOnlyRange() Try re-running Composer update: cf Issue #416 |
How should we do to make it work? Thx |
I ll try to merge the fixes in tonight. |
Cool, merci |
Fixes are merged for both Laravel 4 (1.3.5) as Laravel 5 (2.0.4) versions. |
Thanks! |
Works on my nginx dev server but for some reason it throws an error on my production server running apache.
Any ideas what this is happening? I can definitely see that method so Im not sure why it isnt finding it!
The text was updated successfully, but these errors were encountered: