Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/display comments #26

Merged
merged 4 commits into from Dec 22, 2021
Merged

Feature/display comments #26

merged 4 commits into from Dec 22, 2021

Conversation

MacCrazyman
Copy link
Owner

Display comments feature

This branch edit some functions to make the comments display when the user clicks on the "comments" button:

  • Retrieve information from the Involvement API to get comments
  • Display comments if there are any.
  • Add hover effect to close button in the PopUp window.
  • Connect the "comment" button's event listener to the popUp window

💡

Copy link
Collaborator

@vechicin vechicin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello ✋, @MacCrazyman excellent job! 🔥 🔝

Thanks a lot for changing the HTML file to improve our use of semantic tags, a really good catch! 😄

Please take a look below for a suggested change

@vechicin
Copy link
Collaborator

The change needs to be made in the popup.js file and since you didn't make any changes to it I cannot reference it so here's what I would like you to do:

In line 19, make sure that name.textContent = capitalizeString(selectedPokemon.name), take advantage of the function I created to do that!

That's pretty much it, thanks a lot for your excellent job! 💯

@MacCrazyman
Copy link
Owner Author

The change needs to be made in the popup.js file and since you didn't make any changes to it I cannot reference it so here's what I would like you to do:

In line 19, make sure that name.textContent = capitalizeString(selectedPokemon.name), take advantage of the function I created to do that!

That's pretty much it, thanks a lot for your excellent job! 💯

Thanks for your kind comments @vechicin .

As you requested, the change was implemented in the commit 00680be

name.textContent = capitalizeString(selectedPokemon.name);

🔥

Copy link
Collaborator

@vechicin vechicin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @MacCrazyman, your request is now approved! 🥇

There is nothing else to say other than, it's time to merge it! 🕵️

@vechicin vechicin merged commit c825396 into development Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] - Display comments for a given item on the Comments pop-up - Leonardo
2 participants