New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/display comments #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello ✋, @MacCrazyman excellent job! 🔥 🔝
Thanks a lot for changing the HTML file to improve our use of semantic tags, a really good catch! 😄
Please take a look below for a suggested change
The change needs to be made in the popup.js file and since you didn't make any changes to it I cannot reference it so here's what I would like you to do:In line 19, make sure that name.textContent = capitalizeString(selectedPokemon.name), take advantage of the function I created to do that! That's pretty much it, thanks a lot for your excellent job! 💯 |
Thanks for your kind comments @vechicin .As you requested, the change was implemented in the commit 00680be Line 24 in 00680be
🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Display comments feature
This branch edit some functions to make the comments display when the user clicks on the "comments" button:
💡