Feature/display likes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge is necessary because I need some functions from a branch that was merged a couple of minutes ago.
MacCrazyman
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
Incredible Job @vechicin 🥇
Everything looks good for this part of the project ✔️
I'm approving this pull request and leaving just a little comment for you to implement in your next feature branch.
Congratulations.
Comment on lines
+99
to
+101
| renderLikes().then((response) => getPokemonInfo(response)); | ||
|
|
||
| getPokemonInfo(); | ||
| // getPokemonInfo(); |
There was a problem hiding this comment.
- We can get rid of this commented line as it is already implemented inside the anonymous function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this feature I did the following: