Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphviz's filled and color attributes doesn't work #1138

Open
Gowa2017 opened this issue Dec 31, 2019 · 4 comments · Fixed by #1137
Open

Graphviz's filled and color attributes doesn't work #1138

Gowa2017 opened this issue Dec 31, 2019 · 4 comments · Fixed by #1137
Labels

Comments

@Gowa2017
Copy link
Contributor

Gowa2017 commented Dec 31, 2019

Like

digraph { node [style=filled,color=white]; a -> b }

The result is:
image

On viz-js.com , it seems :

image

I know why!.
The mermaid we use is older version, it's css file 'mermaid.forest.css' override the node's style.

So, If we upgrade the mermeiad, we do not need the mermaid.forest.css file. So it is ok.

Like this:
image

@Gowa2017
Copy link
Contributor Author

Reopen for have same problem too.

We should delete the mermaid stylesheets:

https://github.com/MacDownApp/macdown/blob/master/MacDown/Code/Document/MPRenderer.m#L437

@FranklinYu
Copy link
Member

MWE to reproduce the bug? Please provide the text so it’s easy to copy-paste.

@Gowa2017
Copy link
Contributor Author

MWE to reproduce the bug? Please provide the text so it’s easy to copy-paste.

like this dot code

digraph { node [style=filled,color=blue]; a -> b }

I use blue to fill the node, but the color is memraid's color,as it define a node style which override the vizjs's style.But in memraid v8.3, this mermaid 's forest css file is not needed,so we should delete it.

@FranklinYu
Copy link
Member

Took me a while to reproduce it. Full Markdown:

```dot
digraph { node [style=filled,color=blue]; a -> b }
```

If you enable Graphviz but disable Mermaid then it’s good; only when one enable both Mermaid and Graphviz will this issue be reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants