-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphviz's filled and color attributes doesn't work #1138
Comments
Reopen for have same problem too. We should delete the mermaid stylesheets: https://github.com/MacDownApp/macdown/blob/master/MacDown/Code/Document/MPRenderer.m#L437 |
MWE to reproduce the bug? Please provide the text so it’s easy to copy-paste. |
like this dot code digraph { node [style=filled,color=blue]; a -> b } I use blue to fill the node, but the color is memraid's color,as it define a node style which override the vizjs's style.But in memraid v8.3, this mermaid 's forest css file is not needed,so we should delete it. |
Took me a while to reproduce it. Full Markdown: ```dot
digraph { node [style=filled,color=blue]; a -> b }
``` If you enable Graphviz but disable Mermaid then it’s good; only when one enable both Mermaid and Graphviz will this issue be reproduced. |
Like
digraph { node [style=filled,color=white]; a -> b }
The result is:
![image](https://user-images.githubusercontent.com/33367355/71623818-0998c480-2c1a-11ea-9d8f-47587a4254cb.png)
On viz-js.com , it seems :
I know why!.
The mermaid we use is older version, it's css file 'mermaid.forest.css' override the node's style.
So, If we upgrade the mermeiad, we do not need the mermaid.forest.css file. So it is ok.
Like this:
![image](https://user-images.githubusercontent.com/33367355/71624011-4f09c180-2c1b-11ea-8564-703b504a2ed8.png)
The text was updated successfully, but these errors were encountered: