Unable to use Time Machine function when have a KeyFile

[oehm-smith]

Describe the bug
I am trying to look at the state in the Time Machine backup of Macpass (which is enabled in Database Settings > Advanced > Enable Entry History). The database has a keyfile but trying to choose one drops out of Time Machine so can never look at the chosen historical copy. Subsequent TM attempts have same behaviour (so the Keyfile is not cached like in the 'main' non-historical version).

To Reproduce
Steps to reproduce the behavior:
0. Add a keyfile to the Database Security settings

1. Turn on Entry History ( Database Settings > Advanced > Enable Entry History).
2. Wait a period of time greater than TM backup backups and in this time make changes to an entry
3. With MacPass the foreground app go to Time Machine (Cmd-Space is fine)
4. Select a historical entry. It should show the password entry.
5. Click on Keyfile and it will open a dialog to select a keyfile
6. The historical entry will disappear leaving you at most recent / latest copy

Expected behavior
The keyfile dialog dialog shouldn't escape currently selected historical entry
OR
After selecting keyfile the previously selected historical entry is once again displayed

Screenshots
Not easy to do since all windows look the same

Desktop (please complete the following information):

• macOS: 11.6.2
• Version: 0.7.12

Additional context
none

[georgesnow]

Just to clarify are you trying to view a single entries history or historical version of the entire database? The process for each is actually different.

[mstarke]

I think it is clear that the Time Machine UI is meant. MacPass has no special support for Time Machine. I never dug into this. But you have a valid point since the locked database does not show you much to decide if the backup you will choose is the right one. I have to take some time to look into this but I suspect it might take a while to figure it out.

[georgesnow]

gotcha. The reference to entry history threw me off. 😕

[oehm-smith]

Sorry for no response. Historical view of entire DB.

On the back of this, I'm not sure if the 'backup' is working. Oh sorry I see it is 'recycle bin'. Didn't there used to be a 'backup' - in light of the Time Machine issue this would be good to have (again).

[mstarke]

MacPass now shows the key selection dialog as a sheet rather than a window thus preventing TimeMachine from exiting the version browser.

[oehm-smith]

Great work, thanks