Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Save password generation settings #251

Closed
pimlottc opened this issue Oct 15, 2014 · 5 comments
Closed

[Feature Request] Save password generation settings #251

pimlottc opened this issue Oct 15, 2014 · 5 comments

Comments

@pimlottc
Copy link

Sites are often really picky about password settings - number of characters, allowed characters - and sometimes it takes a bit of trial and error just to figure out what they will accept.

It would be nice if MacPass would remember the password generation settings per entry so that they would be there for the next time you have to change your password.

@mstarke
Copy link
Member

mstarke commented Oct 15, 2014

I would categorise this as a "bit over the top". A better solution might be to just add a "preset" system that allows you to add some custom settings but leave the overall settings just "as-is"

@mstarke
Copy link
Member

mstarke commented Oct 15, 2014

Why over the top? If it's a "per entry" setting, it practically has no "default setting". Might be possible to change it from preset to a checkbox "defaults for entry". But that just makes the user experience a bit complex, at least that's what I think.

@mstarke
Copy link
Member

mstarke commented Oct 28, 2014

fixed in master. Entries now can have a separator generator setting. The UI has loads of potential improvement, but should work for now.

How to use it:

  • open the password generator for an entry
  • check the "use defaults for selected entry" and hit "set defaults" button. Now this entry has special defaults
  • if you want to remove the special settings, press Alt, "set defaults" should now change to "reset" and you can remove the settings for this entry

@mstarke mstarke closed this as completed Oct 28, 2014
@pimlottc
Copy link
Author

pimlottc commented Nov 2, 2014

Cool, thanks. The one suggestion I'd have though, is why not just always save the settings automatically? If the user changed the parameters (and didn't hit cancel) then presumably it was for a reason. It would simplify the UI and you could still use the reset button if you didn't really want to save it.

@mstarke
Copy link
Member

mstarke commented Nov 2, 2014

This is a clash of two use-cases I would guess. What's if someone just wants to quickly use the generator with some settings he/she feels got with today (to put it simple) but without "polluting" the defaults? If the defaults would get set automatically you'd lose them instantly without any means to recover them.

It's debatable whether this is such a bad thing but for me it would be a bit annoying. Might as well use a global setting to change that. But this then opens the door to a lot of questions whether a settings needs to be present or there should be none and the default should work for (most) people.

Problems, problems ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants