HEAD build is not building the correct commit

[mattip]

Any build that is not directly from a tag should have dev in the version or some other way to get more appropriate information. Currently, openblas_get_config() returns something like OpenBLAS 0.3.23 USE64BITINT DYNAMIC_ARCH NO_AFFINITY Zen MAX_THREADS=64 even for builds that are not exactly 0.3.23. It would be nice if it were OpenBLAS 0.3.24-dev .... @martin-frbg is there a way to do that in the make command`?

OpenBLAS is not the problem, we are not properly checking out the commit we want

[martin-frbg]

It should be doing this already (VERSION is defined at build time by the toplevel CMakeLists.txt and Makefile.rule). Maybe your build doesn't because you cherry-picked some PRs on top of a tagged release or something like that ?

[martin-frbg]

btw it is 0.3.23.dev for anything between 23 and 24, although .24-dev might make at least as much sense, I "inherited" that naming scheme

[mattip]

Strange. The builds for the current commit, after #101, have OpenBLAS 0.3.23.dev .... The builds for what should be HEAD have OpenBLAS 0.3.23 .... I wonder if building the HEAD of develop somehow gets the wrong version? Or maybe that CI job is not doing what I think it should be doing?

Indeed, looking at the build log I see git checkout v0.3.23. This is coming from git checkout $OPENBLAS_COMMIT. @honno is that environment variable being reset to develop when running a scheduled build? clean_code, see the next comment

[mattip]

I think when PR #103 was modified to a single yaml file, instead of two separate ones, I did not properly review which commit was used. The call to clean_code should use develop if it is a nightly build