Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Error Handling, No Unit Test #2

Open
StephenClarkApps opened this issue May 20, 2019 · 0 comments
Open

No Error Handling, No Unit Test #2

StephenClarkApps opened this issue May 20, 2019 · 0 comments

Comments

@StephenClarkApps
Copy link

This has both no error handling, and no unit test. Changing the root url to an incorrect URL results in the app crashing as nothing of this is picked up. There seem to be no appropriate handling of URL response code. My understanding of Rx is where a particular sequence which is assuming something would need to be stopped if assumption not met etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant