Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting type definitions #62

Closed
sshin23 opened this issue Aug 27, 2021 · 1 comment
Closed

Revisiting type definitions #62

sshin23 opened this issue Aug 27, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@sshin23
Copy link
Member

sshin23 commented Aug 27, 2021

As mentioned in #58 (comment), several major types in MadNLP include non-concrete types. Because of this, several auxiliary functions are introduced to avoid unnecessary memory allocations. Such introduction of auxiliary functions can be avoided by always using concrete types in the type definition. The following is suggested:

  • Thoroughly revisit the type definitions (NonlinearProgram, Solver, SparseMatrixCOO, etc) and eliminate the abstract types in the type definition.
  • Eliminate the auxiliary functions whenever there's no performance regression.
  • Change Solver -> InteriorPointSolver
@sshin23 sshin23 self-assigned this Aug 27, 2021
@sshin23 sshin23 added the enhancement New feature or request label Aug 27, 2021
@frapac
Copy link
Collaborator

frapac commented Dec 1, 2023

Closing this issue, as the types in MadNLP have been revamped in the recent refactoring #272

@frapac frapac closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants