Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile.onSaved Signal #11

Closed
lucasmz-dev opened this issue Apr 27, 2021 · 4 comments
Closed

Profile.onSaved Signal #11

lucasmz-dev opened this issue Apr 27, 2021 · 4 comments

Comments

@lucasmz-dev
Copy link
Contributor

lucasmz-dev commented Apr 27, 2021

So, I know as of the moment, that saved signals sound useless, they mostly are.
It seems like you're against the idea of having a Signal / Callback which is fired before a auto-save/save happens. I agree with that.
However, I would like one to have as a after-save signal. It can be useful for data-saved notifications and etc.

There are some problems by having a indicator for the player for when their data is auto-saved, like them trying to throttle a profile by leaving as it was saved, but most of the time that's harmless anyway, and it's a developer's choice. I think it would be fine. I personally have something like this on a module I made, for debugging.

In this case, I know you would probably use something like Profile:ListenToSaveCompleted() or Profile:ListenToSucessfulSave() or something to stay consistent.

@Wizertex
Copy link

Would help with dev products so you can see if data was saved (or check when data from MetaTags appears in MetaTagsLatest) without loops

@LM-loleris
Copy link
Member

LM-loleris commented Apr 27, 2021

So, I know as of the moment, that saved signals sound useless, they mostly are.
It seems like you're against the idea of having a Signal / Callback which is fired before a auto-save/save happens. I agree with that.
However, I would like one to have as a after-save signal. It can be useful for data-saved notifications and etc.

There are some problems by having a indicator for the player for when their data is auto-saved, like them trying to throttle a profile by leaving as it was saved, but most of the time that's harmless anyway, and it's a developer's choice. I think it would be fine. I personally have something like this on a module I made, for debugging.

In this case, I know you would probably use something like Profile:ListenToSaveCompleted() or Profile:ListenToSucessfulSave() or something to stay consistent.

I'm trying to keep the ProfileService method collection tight so it would try not to distract amateur developers with false pre-assumptions on how ProfileService might work. However...

Would help with dev products so you can see if data was saved (or check when data from MetaTags appears in MetaTagsLatest) without loops

This might be a valid suggestion and I'm willing to add a signal Profile.MetaTagsUpdated [ScriptSignal] (meta_tags_latest). This signal would be fired after every finished auto-save.

@Wizertex
Copy link

This might be a valid suggestion and I'm willing to add a signal Profile.MetaTagsUpdated [ScriptSignal] (meta_tags_latest). This signal would be fired after every finished auto-save.

Do you have any ETA on that? Don't worry if not, but I just started working on a project so it would be helpful

@LM-loleris
Copy link
Member

Profile.MetaTagsUpdated [ScriptSignal] has been added.
Thank you for your contribution!

See documentation here:
https://madstudioroblox.github.io/ProfileService/api/#profilemetatagsupdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants