Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting error while setting up multi module project #72

Open
slice-saransh-gupta opened this issue Oct 14, 2023 · 4 comments
Open

Getting error while setting up multi module project #72

slice-saransh-gupta opened this issue Oct 14, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@slice-saransh-gupta
Copy link

Was trying to setup jacoco reports for a android multi module project

Rules I have used

      - name: Add coverage to PR
        id: jacoco
        uses: madrapps/jacoco-report@v1.6.1
        with:
          paths: |
            ${{ github.workspace }}/**/build/reports/jacoco/**/jacocoTestReport.xml
          token: ${{ secrets.GITHUB_TOKEN }}
          min-coverage-overall: 40
          min-coverage-changed-files: 80
          update-comment: true
          debug-mode: true
          title: Code Coverage
      - name: Get the Coverage info
        run: |
            echo "Total coverage ${{ steps.jacoco.outputs.coverage-overall }}"
            echo "Changed Files coverage ${{ steps.jacoco.outputs.coverage-changed-files }}"
      - name: Fail PR if changed file coverage is less than 80%
        if: ${{ steps.jacoco.outputs.coverage-changed-files < 80.0 }}
        uses: actions/github-script@v6
        with:
          script: |
            core.setFailed('Overall changed file coverage is less than 80%!')

Error I am getting
Screenshot 2023-10-14 at 7 16 44 PM

@CalixtoElProgramador
Copy link

I have the same issue

@zetbrush
Copy link

Hey there, any update on this issue ? @thsaravana

@CalixtoElProgramador
Copy link

by the way, I managed to solve this by deleting the testing directories that did not contain any test in each of the modules

@zetbrush
Copy link

@CalixtoElProgramador thx for info, in my case jacoco configs are applied to the modules only - that actually contain test classes, and other modules don't contain test folders as well

@thsaravana thsaravana self-assigned this Dec 26, 2023
@thsaravana thsaravana added this to the 1.7 milestone Dec 26, 2023
@thsaravana thsaravana added the bug Something isn't working label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants