Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current app integrations #1

Open
11 tasks done
Maestro-Zacht opened this issue Apr 17, 2023 · 7 comments
Open
11 tasks done

Current app integrations #1

Maestro-Zacht opened this issue Apr 17, 2023 · 7 comments

Comments

@Maestro-Zacht
Copy link
Owner

Maestro-Zacht commented Apr 17, 2023

@cpjet64
Copy link

cpjet64 commented Apr 20, 2023

@ppfeufer
Copy link

@Maestro-Zacht
Copy link
Owner Author

AFAT » https://github.com/ppfeufer/allianceauth-afat

I just checked your app and it doesn't seem it has a login functionality. It requests a token when adding esi fleets but there is no associated action such as registering the user or the token in a model, like other apps do. In addition to that if there is a valid token the user would need to select that anyway when adding an esi FAT, it would just skip the ccp login.

If I'm missing something pls let me know.

@Maestro-Zacht Maestro-Zacht pinned this issue Sep 13, 2023
@ppfeufer
Copy link

ppfeufer commented Sep 13, 2023

Nah, that's pretty much it. Skipping the login and landing directly at the character selection would be the improvement/benefit here. Pretty much "pre-loading" the scopes.

Tokens are requested when:

  • An ESI fleet is created (esi-fleets.read_fleet.v1)
  • A user clicks on a FAT link to register their participation (esi-location.read_location.v1, esi-location.read_ship_type.v1, esi-location.read_online.v1)

@davidrobbins1
Copy link

Corporation Audit. I believe it is part of corp tools https://website.com/audit/corp/r/#/

@Maestro-Zacht
Copy link
Owner Author

Yes it is and i totally missed that. It'll be a little more difficult to implement though, because it require changing how the dynamic import works since atm it accepts 1 entry for each app. I'll do that after completing tests and AFAT integration.

@GurkeTonic
Copy link

It would be great to integrate the following module:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants