Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override JS player/vehicle GetScale/SetScale methods to only use scalar float #49

Open
3 tasks
zpl-zak opened this issue Jan 13, 2024 · 1 comment
Open
3 tasks
Assignees
Labels
enhancement New feature or request priority:low

Comments

@zpl-zak
Copy link
Member

zpl-zak commented Jan 13, 2024

Issue Description

  • The current framework codebase uses a Vector3 structure to specify the scale of entity.
  • MafiaMP relies on a scalar floating point value for model scale, which means it uses uniform scaling.

Action Items

  • Override the setScale and getScale functions within the scripting engine to operate only with scalar floating point values.
  • Reuse one of the Vector3's three components as a storage for the scalar value.
  • Ensure that MafiaMP applies the scalar value directly on the client side via an SDK call to scale the entity properly.
@Deewarz
Copy link
Contributor

Deewarz commented Jan 14, 2024

Check if natives are right:

virtual ue::sys::math::C_Vector GetScale(void) = 0;

virtual void SetScale(float) = 0;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low
Projects
Status: No status
Development

No branches or pull requests

2 participants