Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't hotscript be in the main dependencies since it's imported in dist/index.d.ts? #117

Closed
eych opened this issue May 27, 2023 · 2 comments · Fixed by #112
Closed
Labels
bug Something isn't working

Comments

@eych
Copy link

eych commented May 27, 2023

Hello!

I'm probably missing something, but I'm getting an error during my TS build because dist/index.d.ts from moderndash imports from hotscript, but it's not installed as a dependency — it's listed in devDependencies instead, so it's not in my project at all as a result, although I've run npm install moderndash previously.

The line at the very top of dist/index.d.ts

import { Call, Tuples, Objects } from 'hotscript';

Should hotscript be moved to the main dependencies instead?

@eych eych changed the title Shouldn't hotscript be in the main dependencies since its imported in dist/index.d.ts? Shouldn't hotscript be in the main dependencies since it's imported in dist/index.d.ts? May 27, 2023
@Maggi64 Maggi64 added the bug Something isn't working label May 27, 2023
@Maggi64
Copy link
Owner

Maggi64 commented May 27, 2023

Thank you for the report, having the import there is not intended. It should bundle the definitions. I will look into that.

@Maggi64
Copy link
Owner

Maggi64 commented May 29, 2023

I couldn't get tsup, esbuild to bundle the hotscript dependency into the d.ts file. I moved hotscript to dependencies for now.

@Maggi64 Maggi64 linked a pull request May 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants