Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar doesn't translate events to local time #1568

Closed
rossburton opened this issue Feb 11, 2019 · 8 comments
Closed

Calendar doesn't translate events to local time #1568

rossburton opened this issue Feb 11, 2019 · 8 comments

Comments

@rossburton
Copy link

My calendar has an event on it which is from 15:30 to 16:00 every week. However it appears on my MM calendar as 07:30 to 08:00 because the event was created by a colleague in a different timezone: he's in PST (-0800) and I'm in GMT (+0000).

@MichMich
Copy link
Collaborator

Can you try the dev branche? Might be fixed already.

@narwhalsnarwhals
Copy link

it still isnt

@mlcampbe
Copy link

I am having this problem too on the latest 2.8.0 release.

I am in CT and have colleagues in ET and PT. When an east coast person creates an event then it is off by 1 hours. If a pacific coast person creates an event it is off by 2 hours (the other direction). It is maddening and as a result I can't rely on the times.

Any ideas? Do you want a sample ical file to help debug it?

@mlcampbe
Copy link

I may have found a quick fix for the problem. I did some research and found that the default calendar module uses the node-ical modules to parse calendar data. I notice that it is based off of https://github.com/peterbraden/ical.js. I also found https://github.com/jens-maus/node-ical that is based off of the original peterbraden/ical.js. but seems to have been updated to use the npm package moment-timezone.

I did a drop in replacement and it seems to work:

cd modules/default/calendar/vendor
mv ical.js ical.js.orig
git clone https://github.com/jens-maus/node-ical
mv node-ical/ ical.js
cd ical.js
npm install

Restarted MM and now my timezones are showing up properly. So I made my own modules out of this so it won't get overwritten by updates.

So it seems that the correct fix would be for MM to update the ical.js that it uses.

@rossburton
Copy link
Author

🏅 for @mlcampbe!

@matthiashh
Copy link

I am having the same problem being on a31546b.

Would there be an issue using the apparently updated version of the ical file?
i can create a PR if the proposed solution of @mlcampbe is in line with the projects policies.

@DennisFaucher
Copy link

@mlcampbe Thank you so much. My Exchange calendar ICS was acting extremely funny. I think this may have fixed the issues.

@MichMich
Copy link
Collaborator

MichMich commented Jul 4, 2020

Duplicate #1798, closing.

@MichMich MichMich closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants