Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default calendar needs to use ical as a dependency vs self embedded library. we are woefully behind #1926

Closed
sdetweil opened this issue Feb 10, 2020 · 7 comments

Comments

@sdetweil
Copy link
Collaborator

sdetweil commented Feb 10, 2020

Please only submit reproducible issues.

If you're not sure if it's a real bug or if it's just you, please open a topic on the forum: https://forum.magicmirror.builders/category/15/bug-hunt
Problems installing or configuring your MagicMirror? Check out: https://forum.magicmirror.builders/category/10/troubleshooting

When submitting a new issue, please supply the following information:

Platform: Place your platform here... give us your web browser/Electron version and your hardware (Raspberry Pi 2/3, Windows, Mac, Linux, System V UNIX).

Node Version: Make sure it's version 0.12.13 or later.

MagicMirror Version: Now that the versions have split, tell us if you are using the PHP version (v1) or the newer JavaScript version (v2).
2.10

Description: Provide a detailed description about the issue and include specific details to help us understand the problem. Adding screenshots will help describing the problem.

changes are occuring for the ical data format, and we cannot keep because the base ships the ical and rrule libraries, vs using npm dependencies for them,

Steps to Reproduce: List the step by step process to reproduce the issue.

Expected Results: Describe what you expected to see.

Actual Results: Describe what you actually saw.

Configuration: What does the used config.js file look like? Don't forget to remove any sensitive information!

Additional Notes: Provide any other relevant notes not previously mentioned. This is optional.

@MichMich
Copy link
Collaborator

We have used it as a dependency before, but that gave a lot of issues back then. Might be a good idea to give it another try, though!

@sdetweil
Copy link
Collaborator Author

sdetweil commented Feb 10, 2020

see #1718 #1798 #1877 #1904 #1922

@stale
Copy link

stale bot commented Apr 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 10, 2020
@mdissel
Copy link

mdissel commented Apr 17, 2020

I've got an issue with a yearly repeated event that is shown in the calendar as a monthly recurring event.. Seems related to the mentioned issues

@stale stale bot removed the wontfix label Apr 17, 2020
@stale
Copy link

stale bot commented Jun 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 16, 2020
@rossburton
Copy link

Please do this, there's lots of issues with the calendar.

@rejas
Copy link
Collaborator

rejas commented Jun 30, 2020

Should be closable since #2048 got merged @sdetweil ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants