-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module ID #2
Comments
Fixed. Thank you. |
@Atrate The issue is more complex than I thought. |
@tytydraco Ideas? |
Well it looks like your module is fine: It's found in the JSON, so your repo is live. Have you tried clearing the module cache in MM yet? |
I've cleaned a cache and module appears. Weird the app does not do it by itself when updating info. Should I create zip by myself and place it somewhere? In original rep I shouldn't. |
Very very strange here. Try zipping it anyway and checking. That will check if it's a repo issue or MM issue. |
All right let's play. Now I open MM and try to download and install a module from repo. The same error as above. Then I try to install an attached zip. No problem: |
So that means magisk manager isn't downloading the zip properly. Let's try and see if maybe @Atrate can download it from MM. Is there any logs in the app that show the actual error? |
Frankly speaking I am new with MM. Actually I was even surprised zips are not downloaded at Download folder like original Magisk app did. So if you tell me how to collect any specific logs - I will do. |
I will just wait for @tytydraco to close this issue directly, and wait for next json update before saying anything. |
Should be fixed, it was a Magisk-Modules-Alt-Repo issue, I worked directly with @tytydraco to fix the issue. |
The issue is that the json generator was always using the "master" branch, it use the default repo branch now, so it's fixed now! |
Hey there @gjf ,
I noticed an oversight. In the Submission Guidelines at https://github.com/Magisk-Modules-Alt-Repo/submission, it is stated that:
I have noticed that this is not the case for your module. Could you please fix that?
The text was updated successfully, but these errors were encountered: