-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update.json? #13
Comments
Do you have any issue for using Fox's Magisk Module Manager? I don't like "update.json" feature. |
Thanks for your response! And yes, I do have. For one¹, it doesn't support custom repos. I'm using (actually, maintaining) a module repo which only serves FOSS modules, as I (and several other people) want to stick to FOSS. Actually, "one day" I plan to set up alternatives for fetching modules that do not have TL;DR: having ¹ there are other reasons, but I don't want to go into depth on them here as some of them are rather subjective |
I think Fox's manager can handle a custom repo. Isn't it enough? |
As said, no. FoxMM is a great app (it was me having brought it to F-Droid by the way), but not everyone wants to use it. We love to have a choice 😄 I see like I don't want to be glued to FoxMM, you don't want to use |
To give you some more background, first the obvious:
Next point is I'm coming from a F/LOSS perspective here. For "us F/LOSS folks" it's not sufficient that a module exists and we can download it – we want to know it's F/LOSS. We want to know what license it's covered by, where we can report issues, where the source code is maintained (and we possibly can contribute). Those details are not covered by the "standard repo format" used by the official "Magisk Modules Repo" or the "Alt Repo" (and thus by FoxMMM). Now take a look at this screenshot, taken from my repo's web front-end: The license field is already available with MRepo, the other ones (website, source, issue tracker, translation, donate, category) are on the road-map and currently "custom properties" supported by my web front-end only. MRepo supports both, the traditional and the enhanced format for TL;DR: I could try to establish a separate update mechanism right away. But that would mean I'd have to adjust that later, once the "backlog" at repo-utils has been reduced – and not only in the code for my web front-end, but in the (now custom work-arond) definitions for each of the modules in my repo. I'd prefer avoiding that and rather process the changes in the "proper order". That said, I of course accept your decision to not provide an |
PS: The EULA question was just clarified after I was able to find the embedded page (here it is). It only applies to installations from Play Store, so 🤷♂️ |
OK, it seems that repo-util is capable to create the module ZIP directly from a Git repo. I've just tried that with v1.2.4+1204(I guess the current HEAD is taken), and compared the ZIP to the one attached to the corresponding release here. Structure seems to match – but the variant of |
The released zip was made from my local repo and works well, but Thanks. |
Ah, that explains – thanks, also for fixing the code base that promptly! So if I'd now clone the repo and zip the content, the resulting ZIP should be a fine module, right? Then I'd go and add it to my repo, using the "git clone" method for updating (which would check |
Alternatively: if you could keep the |
Released ZIP files were tested here on various devices, but the resulting ZIP wasn't always tested on multiple devices (probably only one device or so). I recommend to take a ZIP from the latest released one. I hope users read the README carefully. "audio-misc-settings" cannot achieve its potential unless manually reducing jitter as written in the README or using "audio-jitter-silencer". |
I'll gladly do that. But for automated updates to work, I'd either need an
Currently I can only automate update checking when creating the ZIP from Git whenever
I hope they do that for each module they consider installing 🙈 In the future, I hope the Readme will be part of the catalog itself, so it's available prominently right a) on the web front-end and b) inside the repo app (MRepo) – in addition to the repos themselves. Waiting for the corresponding task on the back-end and in the app to be completed. |
I think you can get the latest released zip file by seeking the latest release page. |
Yes, manually – but not automated. The idea is, as pointed out above, to make your module available with the repo mentioned. Using the methods available to repo-util, that's currently not possible for the said reasons: I have no way to tell when to fetch what, as none of the methods matches. If only for that one single letter ( If you take a look at the repo URL, you'll see there are now almost 60 FOSS modules in. Looking "a level up" you will note I also maintain a repo with FOSS Android apps, currently serving more than 1.000 apps. If there are only 10 I have to check manually, that already starts to get "messy" 😉 Hence my kind request: could you maybe just leave out the |
No, No. you can do by using latest release and seeking the url of the latest module zip file. If you need to get its version code lightly, fetch it from its repo source. |
Yes, I can do that manually – repo-util doesn't support that. For that I'd need something to directly match on, as outlined above. Would it really be hard to have the |
Don't use "version". It's just a name. "versionCode is the true version to be checked automatically. |
Couldn't agree more 🤣 Unfortunately, that's not how I could build a bridge from
🥳 Great, thanks! So tag & file name will have a lower-case |
You can automatically make a local update.json with a simple script for any module on the Github. |
Yes, I'm doing that already with 14 modules not having their own {
"version": "2.2",
"versionCode": 9,
"moduleProp": "https://github.com/HuskyDG/zygisk_proc_monitor/raw/master/magisk-module/module.prop",
"urlPattern": "https://github.com/HuskyDG/zygisk_proc_monitor/releases/download/v%v/magisk-am-proc-start-tool-v%v.zip",
"zipUrl": "https://github.com/HuskyDG/zygisk_proc_monitor/releases/download/v2.2/magisk-am-proc-start-tool-v2.2.zip",
"changelog": ""
} My updater script checks against the corresponding I cannot have different routines for each module though, that soon gets hard to maintain. You have a case mismatch, the next one has an extra string in Better keep it simple and maintainable. So I wait for your next release, which then hopefully has a "matching cased |
It's not true. You can do automatically by modifying your codes for any module universally on the Github. The Github knows the latest release tag. You can obtain it from Github's server responses. See my script at the previous response. |
As pointed out, I cannot write a specific update script for each module, that gets too messy (also consider that 1) not all modules are hosted at Github, 2) not all used tagged releases, 3) some always stick to pre-release which Thanks for offering the script, though! |
I updated my Magisk modules for Magisk 26.0's new magic mount feature. IMHP your approach isn't promising. Module file names vary often and for any reason. Edit: my improved script |
As I wrote:
repo-util offers to use either I don't want to add more complexity to that (at least not at this time), but will keep your script here should it be needed. Thanks a lot for your efforts, much appreciated! And special thanks for the "synced |
Could you please add (and maintain) an
update.json
for automated fetching of new releases? Thanks in advance!The text was updated successfully, but these errors were encountered: