Button Border not Transparent when Focused. #2767

Closed
feinstein opened this Issue Dec 16, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@feinstein
Contributor

feinstein commented Dec 16, 2016

What steps will reproduce this issue?

Place a Button inside a Flyout with some backgound color (mine id Cobalt Accent). When the Button has Focus, it's possible to see some of the white background coming off the corners of the border:

image

Expected outcome

No white background on the corners.

--

Environment

  • MahApps.Metro v1.3.0
  • Windows 10
  • Visual Studio 2015
  • .NET Framework 4.5

@punker76 punker76 self-assigned this Dec 16, 2016

@punker76 punker76 added this to the 1.4.0 milestone Dec 16, 2016

@punker76 punker76 added the Bug label Dec 16, 2016

@punker76 punker76 closed this in 4e91cf4 Dec 16, 2016

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Dec 16, 2016

Member

@feinstein This will be fixed in upcoming 1.4.0. The ToggleButton had the same issue and is now also fixed.

image

image

image

Member

punker76 commented Dec 16, 2016

@feinstein This will be fixed in upcoming 1.4.0. The ToggleButton had the same issue and is now also fixed.

image

image

image

@feinstein

This comment has been minimized.

Show comment
Hide comment
@feinstein

feinstein Dec 16, 2016

Contributor

@punker76 will #2458 be fixed as well?

Contributor

feinstein commented Dec 16, 2016

@punker76 will #2458 be fixed as well?

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Dec 16, 2016

Member

@feinstein No, cause this would be a visual breaking change

Member

punker76 commented Dec 16, 2016

@feinstein No, cause this would be a visual breaking change

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Dec 16, 2016

Member

@feinstein And why fixing? It's not a bug, it's in this case a feature (IsKeyboardFocusWithin). If you don't like it (and for a workaround), create a copy and remove this lines.

Member

punker76 commented Dec 16, 2016

@feinstein And why fixing? It's not a bug, it's in this case a feature (IsKeyboardFocusWithin). If you don't like it (and for a workaround), create a copy and remove this lines.

@feinstein

This comment has been minimized.

Show comment
Hide comment
@feinstein

feinstein Dec 16, 2016

Contributor

@punker76 oh, ok, I got the impression it was a clicked state and not a IsKeyboardFocusWithin state, I will close the other issue then.

Contributor

feinstein commented Dec 16, 2016

@punker76 oh, ok, I got the impression it was a clicked state and not a IsKeyboardFocusWithin state, I will close the other issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment