New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] [Enhancement] Proposed TabControlHelper.IsUnderlined Change #2895

Closed
amkuchta opened this Issue Mar 17, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@amkuchta
Contributor

amkuchta commented Mar 17, 2017

Description

Since the TabControl got an underline a while back, I have wanted to update it to have an underline all the way across, but wasn't able to get around to it. I wanted to put the idea to a vote and see how the community at large feels. If you like it, please 👍 . If you would prefer to keep the underline how it is, please 👎 . As always, @punker76 and the rest of the contributors, please feel free to override me. Additionally, I can look into creating a new attached property, e.g. TabControlHelper.UnderlineHeaderPanel to make it an optional feature.

Sample Screenshot

updatedtabcontrolunderline

@amkuchta

This comment has been minimized.

Show comment
Hide comment
@amkuchta

amkuchta Mar 17, 2017

Contributor

@flagbug @Amrykid @laicasaane @Malavos @DylanDoppelt @100GPing100 since you guys all had some input for the original underline, I am especially interested in hearing what you have to say about this

Contributor

amkuchta commented Mar 17, 2017

@flagbug @Amrykid @laicasaane @Malavos @DylanDoppelt @100GPing100 since you guys all had some input for the original underline, I am especially interested in hearing what you have to say about this

@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Mar 17, 2017

Member

@amkuchta I'll look what we can do

Member

punker76 commented Mar 17, 2017

@amkuchta I'll look what we can do

@punker76 punker76 self-assigned this Mar 17, 2017

@amkuchta

This comment has been minimized.

Show comment
Hide comment
@amkuchta

amkuchta Mar 17, 2017

Contributor

@punker76 I can handle this one if you'd rather assign me to it. I already started working it in on my side, and can take this off of your plate

Contributor

amkuchta commented Mar 17, 2017

@punker76 I can handle this one if you'd rather assign me to it. I already started working it in on my side, and can take this off of your plate

@amkuchta

This comment has been minimized.

Show comment
Hide comment
@amkuchta

amkuchta Mar 17, 2017

Contributor

I'm trying to pull my weight 😆

Contributor

amkuchta commented Mar 17, 2017

I'm trying to pull my weight 😆

@100GPing100

This comment has been minimized.

Show comment
Hide comment
@100GPing100

100GPing100 Mar 17, 2017

Contributor

As long as it stays optional and does not break any current features I'd say why not 👍

Contributor

100GPing100 commented Mar 17, 2017

As long as it stays optional and does not break any current features I'd say why not 👍

@amkuchta

This comment has been minimized.

Show comment
Hide comment
@amkuchta

amkuchta Mar 17, 2017

Contributor

@punker76 I'll work this on https://github.com/amkuchta/MahApps.Metro/tree/underlined_tabcontrol_enhancement. You'll see a PR for it sometime this weekend.

Contributor

amkuchta commented Mar 17, 2017

@punker76 I'll work this on https://github.com/amkuchta/MahApps.Metro/tree/underlined_tabcontrol_enhancement. You'll see a PR for it sometime this weekend.

@punker76 punker76 added this to the 1.5.0 milestone Mar 21, 2017

@punker76 punker76 referenced this issue Mar 21, 2017

Merged

TabControl Underlined TabPanel #2902

1 of 1 task complete

@punker76 punker76 closed this in #2902 Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment