Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] [Enhancement] Proposed TabControlHelper.IsUnderlined Change #2895

Closed
amkuchta opened this issue Mar 17, 2017 · 6 comments
Closed

[RFC] [Enhancement] Proposed TabControlHelper.IsUnderlined Change #2895

amkuchta opened this issue Mar 17, 2017 · 6 comments
Assignees
Milestone

Comments

@amkuchta
Copy link
Contributor

amkuchta commented Mar 17, 2017

Description

Since the TabControl got an underline a while back, I have wanted to update it to have an underline all the way across, but wasn't able to get around to it. I wanted to put the idea to a vote and see how the community at large feels. If you like it, please 👍 . If you would prefer to keep the underline how it is, please 👎 . As always, @punker76 and the rest of the contributors, please feel free to override me. Additionally, I can look into creating a new attached property, e.g. TabControlHelper.UnderlineHeaderPanel to make it an optional feature.

Sample Screenshot

updatedtabcontrolunderline

@amkuchta
Copy link
Contributor Author

@flagbug @Amrykid @laicasaane @Malavos @DylanDoppelt @100GPing100 since you guys all had some input for the original underline, I am especially interested in hearing what you have to say about this

@punker76
Copy link
Member

@amkuchta I'll look what we can do

@punker76 punker76 self-assigned this Mar 17, 2017
@amkuchta
Copy link
Contributor Author

@punker76 I can handle this one if you'd rather assign me to it. I already started working it in on my side, and can take this off of your plate

@amkuchta
Copy link
Contributor Author

I'm trying to pull my weight 😆

@zeluisping
Copy link
Contributor

As long as it stays optional and does not break any current features I'd say why not 👍

@amkuchta
Copy link
Contributor Author

@punker76 I'll work this on https://github.com/amkuchta/MahApps.Metro/tree/underlined_tabcontrol_enhancement. You'll see a PR for it sometime this weekend.

@punker76 punker76 added this to the 1.5.0 milestone Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants