Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Single Page Application #5

Merged
merged 21 commits into from Sep 21, 2022
Merged

Create Single Page Application #5

merged 21 commits into from Sep 21, 2022

Conversation

MahdiSohaily
Copy link
Owner

Awesome Books Project: Create Single Page Application

In this branch, we have made the following changes: ☺️

  • Added Form component class.
  • Added List component class.
  • Added Contact component class.
  • Added Book class blueprint.
  • Added Book Controller class.
  • Added Style of the main page.

Copy link

@Mihndim2020 Mihndim2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED!!! 🎉 🎉 🎉 🍾 🍾 🍾

Hi @MahdiSohaily,

Good job !!!

To Highlight! 👏 🟢

✔️ Good commit messages
✔️ Clean/Organized code
✔️ Descriptive Readme file

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉 🍾 🍾 🍾

Congratulations-Memes-FEATURED

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @Mihndim.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@MahdiSohaily MahdiSohaily merged commit 77467da into main Sep 21, 2022
@MahdiSohaily MahdiSohaily deleted the create-SPA branch September 21, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants