JS Capstone Project #32
Conversation
There was a problem hiding this comment.
Hi @MahdiSohaily and @AlejandraKeber ,
Good job so far. I really like what you did!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Your UI is amazing. Well done
- all your linters are ok
Required Changes ♻️
- You really did a great job but there are some features you need to improve
- Please check the comments below
I'm sure you can do it just keep it up
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/Modules/Render.js
Outdated
| /** WE have the function to get the number of comments for specific card at popup section | ||
| * Here we were also added that but that was causing the application to be slow | ||
| * That is way we have added Random number of comments to have better UI insted | ||
| * of just displaying zeros | ||
| */ |
There was a problem hiding this comment.
- [ optional ] Great job. It's not best practice to have comments everywhere in your script. I think your functions are already self-explanatory.
| <ul class="nav-menu"> | ||
| <img class="close-menu p-300" src="./images/icon-close.svg" alt="close menu icon (cross)"> | ||
| <li><a class="list-item text-dark-grayish-blue" data-content="products" href="javascript:void(0)">Products (<span id="pCount"></span>)</a></li> | ||
| <li><a class="list-item text-dark-grayish-blue" data-content="contact" href="javascript:void(0)">Contact</a></li> | ||
| <li><a class="list-item text-dark-grayish-blue" data-content="about" href="javascript:void(0)">About</a></li> | ||
| </ul> |
There was a problem hiding this comment.
- Hi for your mobile menu ill recommend giving it the highest z-index since it should appear in front of every other element
There was a problem hiding this comment.
Hello @MahdiSohaily & @AlejandraKeber
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Outstanding UI design ✔️
Status: APPROVED 🔥 🔥
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
JS Capstone project: working with API and Testing
This project is the capstone for module two of Microverse Bootcamp and has been done as a team and covered the following topics: