Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leader Board #2

Merged
merged 46 commits into from Oct 11, 2022
Merged

Leader Board #2

merged 46 commits into from Oct 11, 2022

Conversation

MahdiSohaily
Copy link
Owner

Leader Board Project: setup project & create HTML template

In this branch, I have made the following changes:

  • Added project startup files.
  • Added web pack to the project.
  • Added project assets files.
  • Added file loader plugin to the project.
  • Added the CSS loader plugin to the project.
  • Added style loader to the project.
  • Added project HTML structure.
  • Added project CSS reset styles.
  • Added project styles.

Copy link

@brytebee brytebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @MahdiSohaily👋,

Highlights💡

  • Good commit message.✔️
  • Good PR Summary.✔️
  • Great UI design.✔️
  • App functions as it should.✔️

STATUS: APPROVED 🕺🥳

Congratulations🍾🥳!! Your project is ready for presentation! There is nothing else to say other than... it's time to merge it :shipit:

Good luck! 🎉

Optional Suggestions:

  • N/A

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.

Use @brytebee on slack for faster responses.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@MahdiSohaily MahdiSohaily merged commit 45d9c5a into development Oct 11, 2022
@MahdiSohaily MahdiSohaily deleted the setup-project branch October 11, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants