Leader Board

[MahdiSohaily]

Leader Board Project: final design and deployment.

in this branch, I have made the following changes:

• Update the design.
• Added GitHub pages.
• Deployed the project.

[Omar-Muhamad]

Invalid ❌

Hi @MahdiSohaily,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Your Code Review Request is marked as invalid for these reasons:

• Some linters checks are not passed.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

Invalid Code Review Request Does not count into the code reviews limit.

[MahdiSohaily]

Invalid ❌

Hi @MahdiSohaily,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Your Code Review Request is marked as invalid for these reasons:

• Some linters checks are not passed.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request Does not count into the code reviews limit.

I just wanted to solve it till someone reviews it, you were so quick 😄

[codepantha]

REQUIRES CHANGES ♻️

Hi @MahdiSohaily 👋,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

## Highlights 🎯 ✔️ Descriptive PR ✔️ Good commit history ✔️ Professional README ✔️ Leaderboard app working as expected

Required Changes ♻️

Check the comments under the review.

• You have applied beautiful styling to the application but unfortunately, you did not follow the wireframe layout. Please ensure that the layout of your application is consistent with the wireframe design. 👍

Wireframe

Your Design

• The "live demo" link in your README currently points to a to-do list application that has nothing to do with this project. Please update the link to point to a hosted demo of this project or remove it entirely 👍

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

• n/a

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[KDlamini]

Hi @MahdiSohaily 🙋‍♀️,

Excellent work! 💯
You have done a great job implementing all the required changes. 🎊 🥳
Your feature is complete! There is nothing else to say other than... it's time to merge it.
Congratulations!!!

Highlights 🌞

✔️ Webpack configured correctly
✔️ Html follows the wireframe
✔️ Nice job with the styling 👌🏾
✔️ No linter errors

Status: Approved ✔️

Cheers 🥂 and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.