ray_tracing_pipeline: Pass SBT regions as reference instead of slice #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API for vkCmdTraceRaysKHR mandates a single non-null pointer per SBT region to a VkStridedDeviceAddressRegionKHR. While providing more than one such region isn't harmful, passing a slice of length 0 will cause reads in uninitialized memory and undefined behaviour. Converting these parameters from slices to references rids the unnecessary confusion and prevents zero regions from being passed.
38 tasks
MarijnS95
added a commit
that referenced
this pull request
Nov 23, 2023
…gle item In an identical fashion to commit 84624fd ("ray_tracing_pipeline: Pass SBT regions as reference instead of slice (#350)") `cmd_trace_rays_indirect()` also only needs a pointer to a single `StridedDeviceAddressRegionKHR` structure. After all no length is ever passed to the API anywhere, and this could also lead to users passing empty slices, or passing too many elements that are never used. Clear up the confusion by replacing the slice argument with a direct borrow of the struct.
MarijnS95
added a commit
that referenced
this pull request
Nov 23, 2023
…gle item In an identical fashion to commit 84624fd ("ray_tracing_pipeline: Pass SBT regions as reference instead of slice (#350)") `cmd_trace_rays_indirect()` also only needs a pointer to a single `StridedDeviceAddressRegionKHR` structure. After all no length is ever passed to the API anywhere, and this could also lead to users passing empty slices, or passing too many elements that are never used. Clear up the confusion by replacing the slice argument with a direct borrow of the struct.
MarijnS95
added a commit
that referenced
this pull request
Nov 25, 2023
…gle item (#829) In an identical fashion to commit 84624fd ("ray_tracing_pipeline: Pass SBT regions as reference instead of slice (#350)") `cmd_trace_rays_indirect()` also only needs a pointer to a single `StridedDeviceAddressRegionKHR` structure. After all no length is ever passed to the API anywhere, and this could also lead to users passing empty slices, or passing too many elements that are never used. Clear up the confusion by replacing the slice argument with a direct borrow of the struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for vkCmdTraceRaysKHR mandates a single non-null pointer per SBT region to a VkStridedDeviceAddressRegionKHR. While providing more than one such region isn't harmful, passing a slice of length 0 will cause reads in uninitialized memory and undefined behaviour.
Converting these parameters from slices to references rids the unnecessary confusion and prevents zero regions from being passed.