Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainership #20

Closed
wants to merge 9 commits into from
Closed

Maintainership #20

wants to merge 9 commits into from

Conversation

meithecatte
Copy link

@meithecatte meithecatte commented Jan 27, 2019

This fixes #16 and #17, and implements BitFlags::iter as suggested by #14. As the README claims this project is unmaintained, I'd like you to consider this my application for maintaining it.


This change is Reviewable

@MaikKlein
Copy link
Owner

Thanks for the PR, I'll have a look at it later today.

I am not sure what the best practices are for transferring ownership are as this seems like it could be a security concern. Although the crate only has 3k downloads so maybe it doesn't matter at all.

Maybe you should just fork, I link to the fork and you publish a new crate enumflags2? I honestly don't know what the etiquette is.

@MaikKlein
Copy link
Owner

Just fork this repo, I will link to it and then you can publish a new crate. I'll make to sure to push a new version to crates.io that will include a link to your new repo/crate.

I think that is the best option.

@meithecatte
Copy link
Author

Hmm, it's not ideal, but I don't see any better option. I'll close this and publish the new crate in a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proc-macro derive panicked with #[repr(u64)]: assertion failed: index < std::u32::MAX as usize
2 participants