Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Only Bug] commitAsync Error #1397

Closed
ragokan opened this issue Nov 18, 2021 · 12 comments
Closed

[Android Only Bug] commitAsync Error #1397

ragokan opened this issue Nov 18, 2021 · 12 comments

Comments

@ragokan
Copy link

ragokan commented Nov 18, 2021

Describe the bug
Crashes the app on the launch for the old android devices.
You can check the extra section to see the screenshots. I have talked with the users, they say that their application crashes on launch. The devices are old ones, none of them has more than 2 GB ram, and all of them released before 2017. While debugging in some of their phones, I tried try catch, catchError etc. Definitely it is not changing anything.

  • The error does not occur on newer phones and iOS devices.
  • The error does not occur on emulator.
  • I am using the latest version of all packages and Flutter.

To Reproduce
Just start the application.

Extra
image

@mk-dev-1
Copy link

Chrashlytics is showing crashes also on devices from 2019 with 4 GB (Nokia 6.2) and even S21 Ultra - this does not seem to be related to the device….

@MaikuB
Copy link
Owner

MaikuB commented Nov 18, 2021

@ragokan what does your app do on startup though? Also what version of the plugin is it using?

Edit: I did see you say you're using the latest but want to double check

@mk-dev-1 does your app actually use 9.1.2 though? The reason I'm asking is because I previously mentioned 9.1.1 had changes that attempted to fix #1378

@MaikuB
Copy link
Owner

MaikuB commented Nov 18, 2021

I'll be rolling back changes that were done but this will mean #1378 will be reopened. Currently this is the lesser of two evils though I had no response in assisting with testing fixes for #1378 so hopefully that situation improves next time

Edit: published 9.1.3 with the changes reverted

@mk-dev-1
Copy link

May app is using 9.1.2 yes. I specifically published a new version as I realized the issues described here and in #1387 when I used 9.1.1.

Unfortunately I am unable to recreate the issue myself.

Yesterday this affected about 1.5% of users that had the app version that uses 9.1.2. Looking at user streams, it does not seem to prevent them from using the app, i.e. it looks like the app crashes, but not every time....

@MaikuB
Copy link
Owner

MaikuB commented Nov 19, 2021

Can either of you (@ragokan and @mk-dev-1) help with testing changes related to this when it's published then e.g. via beta track of your app? Especially @mk-dev-1 as you had a sample app in #1378 but I wasn't able to reproduce the issue you reported there unless there are steps missing

@davidlepilote not sure if you'll see but FYI I suspect going back to apply() per your original PR #980 is the way to go

@ragokan
Copy link
Author

ragokan commented Nov 19, 2021

@MaikuB hello, thank you for your very fast answer. The app starts normally, without any error.

When this part of the code starts running, the app breaks. Weirdly, the try/catch is not working
image

I report all the errors to the backend, there are no error about notifications.
image

All I know is some of my users can't log in and when I try to check it on Play Store crashes, there are many instances of the error.
I call this method on init/loading screen, they are stuck there and the code stop executing.

@MaikuB
Copy link
Owner

MaikuB commented Nov 19, 2021

@ragokan 9.1.3 should fix the issue though not sure how your app was running into issues with initialisation

@ragokan
Copy link
Author

ragokan commented Nov 19, 2021

@ragokan 9.1.3 should fix the issue though not sure how your app was running into issues with initialisation

Ohh, thank you so much, if anything changes I will let you know. Have a great day.

@mk-dev-1
Copy link

@ragokan: Can you consistenly recreate the issue withe sample code provided above? Does it crash only on real devices or also on the emulator? I am asking since I have not been able to reproduce the issue so far. That is, on an emulator.... will need to try later on a real device.

@ragokan
Copy link
Author

ragokan commented Nov 20, 2021

@ragokan: Can you consistenly recreate the issue withe sample code provided above? Does it crash only on real devices or also on the emulator? I am asking since I have not been able to reproduce the issue so far. That is, on an emulator.... will need to try later on a real device.

Yeah, I can't also reproduce it on the emulator, if it was, it would be easier. For now, I am closing this issue, let us try the new version with the users and see how it is going. Thank you, again.

@iqfareez
Copy link
Contributor

iqfareez commented Nov 22, 2021

Just released new app update few days ago. Had a similar issue with 9.1.2, will try to upgrade to 9.1.4

Google Play Store crashes report on java.util.concurrent.RejectedExecutionException:
Screenshot 2021-11-23 013121
image

@ragokan
Copy link
Author

ragokan commented Nov 23, 2021

With the latest version of plugin, the errors are now gone, thank you.
(By the way, some of the users' application was crashing, not because of this bug, but because of bad certificate error on old devices. So the error was just disabling the local notifications for the user.)

@ragokan ragokan closed this as completed Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants