-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification.MessagingStyle support on Android #159
Comments
I assume that you've linked Notification.MessagingStyle to instead of NotificationCompat.MessagingStyle to provide richer notifications? If so, it would sound like, and correct me if I'm wrong, for API 28+ Notification.MessagingStyle should be used. This would in turn mean that plugin will need to switch to using Notification.Builder instead of NotificationCompat.Builder For API < 27, can use NotificationCompat.MessagingStyle. The API surface of the plugin should still provide the means to specify the details of each person |
I have no strong opinion, I just noticed that this style wasn't offered by the plugin but is listed in the Android documentation. |
Noted, this is partly due to not being able to version 28 of the support library before. I had updated the support library to 28 at one but had to downgrade again as apparently other devs had pointed out there was an issue with Flutter when it came to using that version of the library. Though I've noticed you've said there that you've believed it's fixed now. Was also hoping to migrate to AndroidX but from what I gather, there are open issues (e.g. flutter/flutter#23995) on that so guess will have to defer that to later Edit: nvm misread a bit of the documentation on NotificationCompat.MessagingStyle, thinking that it was only supported in support library v 28.0 |
Given the plugin has been migrated to AndroidX, it looks like there's no need to be concerned with branching off the code anymore. AndroidX has the Person class that was appeared to be missing in the support library |
Added in v0.5.1. Let me know if you've got any feedback :) |
Closing this. Please feel free to reopen if you feel there's something missing |
https://developer.android.com/reference/android/app/Notification.MessagingStyle
The text was updated successfully, but these errors were encountered: