Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: ACTION_BOOT_COMPLETED verification fails MY_PACKAGE_REPLACED broadcast #689

Closed
nadavfima opened this issue Jun 29, 2020 · 4 comments

Comments

@nadavfima
Copy link
Contributor

nadavfima commented Jun 29, 2020

The next line would fail any potential MY_PACKAGE_REPLACED broadcasts you might want to listen to:

When an android app is updated, all set alarms are cancelled.
Therefore, we'll need to reschedule all notifications when update is complete.

So we need to remove this verification (or add to it?), and maybe even recommend using MY_PACKAGE_REPLACED as well in the README.

@MaikuB
WDYT? Should I create a Pull Request?

@MaikuB
Copy link
Owner

MaikuB commented Jun 29, 2020

Yeah a PR would be great though if you know of ways to reproduce this locally (off memory it can be done with ADB) so that I can also confirm the solution in the PR works then that would be great.

My thinking is that if it's possible, the PR should add that as intent to check reduce the amount of changes developers need to do on their end. Some already have issues figuring out how to edit the manifest file as well

@nadavfima
Copy link
Contributor Author

Yea, reproducing this just takes reinstalling the APK via ADB.

So I'll fork and create the PR tomorrow. Shouldn't take too long.
I'll add the new action to the verification statement, and add it to the readme.

@MaikuB
Copy link
Owner

MaikuB commented Jun 29, 2020

Sounds great and thanks for catching this

@MaikuB
Copy link
Owner

MaikuB commented Jul 7, 2020

Released now, thanks :)

@MaikuB MaikuB closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants