Bad Mem Access when a file in an email doesn't have a filename

[dwsolberg]

Sometimes a file will arrive with no filename property set. Calling decoded filename on such an attachment results in a memory access crash -- the nil pointer is converted to a char* and used for comparison, which causes the crash.

One potential fix is:

-(NSString *)decodedFilename {
if (self.filename) {
return MailCoreDecodeMIMEPhrase((char *)[self.filename UTF8String]);
}
else {
return nil;
}
}

You could also be smarter about it and return a generic filetype with the correct ending based on the mime type.