Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of deep structures using import in update mode #2601

Merged
merged 2 commits into from Dec 27, 2022

Conversation

ghostwheel42
Copy link
Contributor

What type of PR?

bug-fix

What does this PR do?

Fixes creation of deep structures (ie user with fetch) when using config-import in update mode.

Related issue(s)

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2022

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors bot added a commit that referenced this pull request Dec 27, 2022
@bors
Copy link
Contributor

bors bot commented Dec 27, 2022

try

Build failed:

@ghostwheel42
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Dec 27, 2022
@bors
Copy link
Contributor

bors bot commented Dec 27, 2022

try

Build succeeded:

@ghostwheel42 ghostwheel42 added priority/p0 Critical bug without workaround / Must have type/bug Bug. Not working as intended type/backport Automatic backport this PR to the current stable release python Pull requests that update Python code labels Dec 27, 2022
Copy link
Contributor

@nextgens nextgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 27, 2022

Build succeeded:

@bors bors bot merged commit c729954 into Mailu:master Dec 27, 2022
bors bot added a commit that referenced this pull request Dec 27, 2022
2602: Fix creation of deep structures using import in update mode (backport #2601) r=mergify[bot] a=mergify[bot]

This is an automatic backport of pull request #2601 done by [Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the [documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- ``@Mergifyio` refresh` will re-evaluate the rules
- ``@Mergifyio` rebase` will rebase this PR on its base branch
- ``@Mergifyio` update` will merge the base branch into this PR
- ``@Mergifyio` backport <destination>` will backport this PR on `<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
@ghostwheel42 ghostwheel42 deleted the fix_import branch January 12, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/p0 Critical bug without workaround / Must have python Pull requests that update Python code type/backport Automatic backport this PR to the current stable release type/bug Bug. Not working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config-import [KeyError] 'id'
2 participants