Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAISTRA-1153: adds ability to read pods and services for ior #328

Merged
merged 2 commits into from Feb 6, 2020
Merged

MAISTRA-1153: adds ability to read pods and services for ior #328

merged 2 commits into from Feb 6, 2020

Conversation

bartoszmajsak
Copy link
Contributor

No description provided.

Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run make update-1.1-charts and commit the changes as well

@rcernich
Copy link
Contributor

rcernich commented Feb 6, 2020

Whoops, what @jwendell said. Change looks good, but charts need to be regenerated or it won't get applied on install.

@bartoszmajsak
Copy link
Contributor Author

Whoops, what @jwendell said. Change looks good, but charts need to be regenerated or it won't get applied on install.

Sure, will do. Can this be automated though? i.e. GitHub action / prow job reacting on certain file changes should do the job, right? This way we always going to have consistency.

@bartoszmajsak
Copy link
Contributor Author

bartoszmajsak commented Feb 6, 2020

Something is not right with this target, getting following changes all over the place

-    maistra-version: 1.1.0
+    maistra-version: 1.0.5

@jwendell
Copy link
Member

jwendell commented Feb 6, 2020

make sure to run that command while checked out at ior_roles branch

@bartoszmajsak
Copy link
Contributor Author

make sure to run that command while checked out at ior_roles branch

I did. It turned out that I had MAISTRA_VERSION env var exported for some earlier shell-fu I was fiddling with and that is used by this target as well.

@mergify mergify bot merged commit e150d28 into maistra:maistra-1.1 Feb 6, 2020
@bartoszmajsak bartoszmajsak deleted the ior_roles branch February 6, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants