Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): support creation and deletion of session without keeping cli alive #252

Merged
merged 10 commits into from Sep 20, 2019
Merged

feat(cli): support creation and deletion of session without keeping cli alive #252

merged 10 commits into from Sep 20, 2019

Conversation

aslakknutsen
Copy link
Member

@aslakknutsen aslakknutsen commented Sep 5, 2019 •
edited 

ike create --session x --deployment y --image docker.io/x:latest

ike delete --session x --deployment y

fixes #233
fixes #234

@aslakknutsen aslakknutsen marked this pull request as ready for review September 18, 2019 10:18
@aslakknutsen aslakknutsen changed the title feat(cli): support creation of session without deletion on exit feat(cli): support creation and deletion of session without keeping cli alive Sep 18, 2019
golangcibot
golangcibot reviewed Sep 18, 2019
View reviewed changes
pkg/internal/session/session.go Outdated Show resolved Hide resolved
pkg/cmd/delete/delete_suite_test.go Outdated Show resolved Hide resolved
pkg/cmd/create/create_suite_test.go Outdated Show resolved Hide resolved
@aslakknutsen
feat(cli): support creation and deletion of session without keeping c…
0ad6ca1 
…li alive

    ike create --session x --deployment y --image docker.io/x:latest

    ike delete --session x --deployment y

fixes #233
fixes #234
@aslakknutsen
fix(e2e): include namespace in image ref
7b662ba
@aslakknutsen
fix(lint): stuff
63baa88
@aslakknutsen
fix(e2e): add host header
70d810d
bartoszmajsak
bartoszmajsak reviewed Sep 18, 2019
View reviewed changes
e2e/smoke_test.go Outdated Show resolved Hide resolved
@bartoszmajsak bartoszmajsak added the kind/enhancement Kind: New feature or improvement label Sep 19, 2019
@aslakknutsen aslakknutsen merged commit c1af593 into master Sep 20, 2019
@aslakknutsen aslakknutsen deleted the cli_create branch September 20, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszmajsak bartoszmajsak bartoszmajsak left review comments

@golangcibot golangcibot golangcibot left review comments

Assignees
No one assigned
Labels
kind/enhancement Kind: New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce ike delete command Introduce ike create command
3 participants
@aslakknutsen @bartoszmajsak @golangcibot