Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAISTRA-1159 Add missing label "release" to CRDs #77

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Feb 7, 2020

Some of CRDs are missing the "release" label. Our patch-charts.sh script only adds the maistra-release label to all objects that have the release label. The end result is that these CRDs don't have the maistra-release label, which is crucial for multi-version CRD handling.

Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 1.1 branch (Istio 1.4) suffer from this as well?

@luksa
Copy link
Contributor Author

luksa commented Feb 13, 2020

Does 1.1 branch (Istio 1.4) suffer from this as well?

No.

@mergify mergify bot merged commit 755a340 into maistra-1.0 Feb 18, 2020
@bartoszmajsak bartoszmajsak deleted the MAISTRA-1159 branch October 27, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants