-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.20.2 Linux Client Crashes with Kethane 0.4.4 through 0.5.1 #78
Comments
I've played around with this a little more, and the parts that are causing the crash seem to be both detectors and the drill. Ships mounted with the converter don't cause a crash, but I'm not able to test actually converting Kethane. EDIT: I edited one of the tank parts to start with some Kethane to test that converting doesn't cause a crash. Conversion seems to work fine. |
Thanks for the quality report! I have a hunch why this is happening, and I think the deposit saving changes coming in the next version will resolve the issue. That update is coming very soon, so let's try again then. In the meantime, do the Kethane PluginData folder and its contents have write permissions set correctly? I think the crash happens when Kethane tries to save its data. |
My user (grahjm2a) has write permission to everything under $ pwd
/opt/KSP_linux/GameData/Kethane
$ ls -al
total 20K
drwx------ 5 grahjm2a users 4.0K Jun 9 10:05 .
drwxr-xr-x 4 grahjm2a users 4.0K Jun 9 10:05 ..
drwx------ 14 grahjm2a users 4.0K Jun 9 10:05 Parts
drwx------ 3 grahjm2a users 4.0K Jun 9 10:05 Plugins
drwx------ 2 grahjm2a users 4.0K Jun 9 10:05 Resources
$ ls -al Plugins/
total 48K
drwx------ 3 grahjm2a users 4.0K Jun 9 10:05 .
drwx------ 5 grahjm2a users 4.0K Jun 9 10:05 ..
-rw-r--r-- 1 grahjm2a users 34K Jun 9 10:05 MMI_Kethane.dll
drwx------ 3 grahjm2a users 4.0K Jun 9 10:05 PluginData
$ ls -al Plugins/PluginData/
total 12K
drwx------ 3 grahjm2a users 4.0K Jun 9 10:05 .
drwx------ 3 grahjm2a users 4.0K Jun 9 10:05 ..
drwx------ 3 grahjm2a users 4.0K Jun 9 10:08 MMI_Kethane
$ ls -al Plugins/PluginData/MMI_Kethane/
total 404K
drwx------ 3 grahjm2a users 4.0K Jun 9 10:08 .
drwx------ 3 grahjm2a users 4.0K Jun 9 10:05 ..
-rw-r--r-- 1 grahjm2a users 658 Jun 9 10:38 Bop.png
-rw-r--r-- 1 grahjm2a users 319K Jun 9 13:38 Deposits.dat
-rw-r--r-- 1 grahjm2a users 658 Jun 9 10:38 Dres.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Duna.png
-rw-r--r-- 1 grahjm2a users 658 Jun 9 10:38 Eeloo.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Eve.png
-rw-r--r-- 1 grahjm2a users 658 Jun 9 10:38 Gilly.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Ike.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Jool.png
-rw-r--r-- 1 grahjm2a users 1.1K Jun 9 10:38 Kerbin.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Laythe.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Minmus.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Moho.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Mun.png
-rw-r--r-- 1 grahjm2a users 658 Jun 9 10:38 Pol.png
-rw-r--r-- 1 grahjm2a users 881 Jun 9 10:38 Sun.png
-rw-r--r-- 1 grahjm2a users 1.3K Jun 9 10:38 Tylo.png
-rw-r--r-- 1 grahjm2a users 1.2K Jun 9 10:38 Vall.png
-rw-r--r-- 1 grahjm2a users 136 Jun 9 10:05 YouAreHereMarker.png
drwx------ 2 grahjm2a users 4.0K Jun 9 10:05 sounds
$ ls -al Plugins/PluginData/MMI_Kethane/sounds/
total 156K
drwx------ 2 grahjm2a users 4.0K Jun 9 10:05 .
drwx------ 3 grahjm2a users 4.0K Jun 9 10:08 ..
-rw-r--r-- 1 grahjm2a users 133K Jun 9 10:05 echo_deposit.wav
-rw-r--r-- 1 grahjm2a users 9.0K Jun 9 10:05 echo_empty.wav |
Everything looks right there, and the logs aren't very helpful, so I'm not sure how to help you except to get the next update pushed out. If that doesn't resolve the issue, I'll boot up a Linux VM and see if I can't reproduce it. |
I look forward to the next update. Thanks for taking a look. |
I've just released 0.5. Give it a try and let me know what happens. |
I won't have time to test for a couple days, but I will test by this coming weekend at the latest. Thanks for the heads up that 0.5 is released. |
I lied, I couldn't wait. There seems to be an improvement. Now if I don't have both a detector and a drill, I can launch and end flight successfully. This is a weird error. Using the same procedure as above, the first crash happened when when switching to flight mode out of the VAB, before I even got into flight. I wasn't able to replicate this, so let's assume that it was a fluke. I duplicated my above procedure and then ended flight and returned to the VAB. I then added a drill and storage tank, relaunched, and at that point the game crashed. I tried this a couple times, with the same results. For another test, I built a pod with a tank and a drill (no detector) and was able to launch and end flight successfully. Adding a detector again caused a crash. As a final test, I built my pod/detector part test vehicle, and repeatedly launched it over and over again, without crashes. After a few times, I added a Kethane tank and a drill, launched, and the game then crashed. The end of my logs for the last crash are below. Again, I don't see any useful stack trace or similar, but at least there is some Kethane specific logging info this time. If there is a specific pattern you would like to try, let me know. KSP.log
Unity Player.log
|
Fascinating. Can you try with two detectors? Two drills? The change in behavior makes some sense. Prior to 0.5, detectors and extractors would both call The part that doesn't make sense is that it does it on launch, which AFAIK does not call Can you try loading a ship with the debugger part and open its map view? Its possible that anything instantiating a |
At work at the moment, but wanted to verify: does the 0.4.4 debug part still work with 0.5? Your forum post still points to 0.4.4 debugger. |
That post indicates the debugger works for version 0.4.4-0.5. The debugger doesn't require updates as often as the main build. |
can you try doing this to your ksp binary, I've found that it helps with crashes (this is if you are running on amd64) $ xxd -s +0x7cebc7 -l 1 KSP.x86_64 $ xxd -s +0x7cebcc -l 1 KSP.x86_64 |
@prometheanfire, I'm reluctant to modify my binary without understanding better what that does exactly. I understand we're flipping a bit, but I would like to know what the effect of that is. If there is indeed a bug with the binary, that should be reported to Squad. I haven't experienced a significant number of crashes without Kethane. |
@Majiir, I updated to the 0.5.1 Kethane release before continuing testing. Today, I had several instances where I was getting crashes, but they aren't as consistent as they used to be. One area of frequency crashing (about 3/4 of game starts) happens as follows:
Another smaller percentage of game starts crash on the following launch. I didn't get this to happen enough to figure out if adding more parts triggered this or not. But once when starting a new game (out of about a dozen times), I could repeatedly launch crafts with all sorts of configurations, including the debugger, multiple detectors, multiple drills, drills and detectors, ... I also tried starting the game with a pod / debugger combination a few times (and then relaunching with the identical ship). I didn't have a crash, but as soon as I tried to launch again with a detector there was a crash. I'm really stumped as to what might be wrong. For comparison, I tried again multiple times restarting the game and launching and relaunching without any Kethane components, but never had a crash. Perhaps if you were to make a special log spamming build that I could test with, it would give us more insight into where exactly the crash is occurring. I don't mind doing multiple runs with different configurations to narrow this down. I really want to be able to use this plugin. |
It modifies the code in loading textures (I think). It came from here. |
@prometheanfire Interesting. I'm not having the exact same problems as these folks with not being able to load the game, but when I do patch the binary, it does seem to solve the problem. Thanks for pointing to that forum thread. @Majiir, I suggest that you browse the thread, but it looks like the problem is occurring in Squad's code. I just doesn't manifest in my case unless Kethane is loaded to increase the amount of memory allocated beyond a 32 bit address space. I'm going to close this as it seems my issue has been resolved. |
Alternative explanation: since the problem referenced in the thread seems to be deal with PNG loading code, and the maps are saved as PNGs, the problem may have arisen when those PNG needed to be read. |
I'm getting a crash whenever I have the Kethane mod installed. This crash does not occur when Kethane is not included.
Let me know if I can provide additional information or you would like me to try something different.
Test Environment
Linux, KSP 0.20.2, newly added Kethane 0.4.4, no other mods.
Note that crashes will still occur even if Kethane has not been newly installed, but with a newly installed Kethane the crash is consistent as to when it occurs.
Steps to Reproduce
Linked here is a gist containing the
KSP.log
and the UnityPlayer.log
starting at the VAB until crash.I've had some difficulty creating a consistent test case (sometimes the crash will happen sooner in the process on subsequent runs with Kethane already installed, like at the start of switching to flight mode), but for a newly added Kethane install, it always crashes as above.
The text was updated successfully, but these errors were encountered: