Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using this without authentication? #33

Closed
iMrDJAi opened this issue May 17, 2021 · 3 comments · Fixed by #32
Closed

Using this without authentication? #33

iMrDJAi opened this issue May 17, 2021 · 3 comments · Fixed by #32
Assignees
Labels
enhancement New feature or request P1 Highest priorities
Projects

Comments

@iMrDJAi
Copy link
Contributor

iMrDJAi commented May 17, 2021

Should we login to see posts from public groups? No.
I guess you should make an option to skip authentication, this is pointless in this case, unless there are limitations I'm not aware of.
Good job btw, I'm very excited for the NodeJS module support! <3

@kaanyagci kaanyagci self-assigned this May 20, 2021
@kaanyagci
Copy link
Contributor

Hello @iMrDJAi !

Thank you very much for your feedback. Actually, a great idea to add the skip login option for Facebook public groups. TBH I did not know there are public groups on Facebook. I will add ASAP.

Thank you for the NodeJS module support. Normally the pull request is ready, but I need to test and re-implement the CLI tool with the module before releasing it. If you want to give it a try, you can refer to #32.

Stay tuned 😎 🤓

@kaanyagci kaanyagci added the enhancement New feature or request label May 20, 2021
@kaanyagci kaanyagci added this to To do in npm module May 20, 2021
@iMrDJAi
Copy link
Contributor Author

iMrDJAi commented May 20, 2021

@kaanyagci You're welcome, I really like this project, it can be even better than that!
I wanna provide you some suggestions:

  • For now the scraper provides you limited data, 2 fields only aren't enough for advanced use-cases, what I'm trying to do is using the Reddit API to automatically repost form my Facebook group to my Subreddit, images and videos, post link, author profile link... are needed.
  • You should probably switch to the computer version of the website to get HQ media, the mobile version seems easy to scrape but it gives you low quality.
  • You need to build a class for posts data, because you can't really extract everything from a single post at once, for example Facebook doesn't provide a direct link for videos, you'll have to render the video with another implementation in a separate function.

I'll probably look up for solutions to achieve that, I'll tell you if I found something useful.

@kaanyagci kaanyagci added the P1 Highest priorities label May 28, 2021
@kaanyagci kaanyagci linked a pull request May 30, 2021 that will close this issue
npm module automation moved this from To do to Done May 30, 2021
@kaanyagci
Copy link
Contributor

Hi, @iMrDJAi !

The version 4.0.0 actually merged on master and published on npm. With the module approach you can skip the authentication or you can also use the CLI fbjs-cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Highest priorities
Projects
Development

Successfully merging a pull request may close this issue.

2 participants