Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min node and npm version in README #56

Closed
kaanyagci opened this issue Jul 12, 2021 · 0 comments · Fixed by #60
Closed

Update min node and npm version in README #56

kaanyagci opened this issue Jul 12, 2021 · 0 comments · Fixed by #60
Assignees
Labels
documentation Improvements or additions to documentation P1 Highest priorities
Projects

Comments

@kaanyagci
Copy link
Contributor

For the README lines you're right. The written version is the version that I'm using on my computer, but if you node v14.17.2 works great, I'll update this. Do you mind share your npm version too?

@kaanyagci Sure, my npm version is 6.14.13, but this doesn't change the fact that it may work on a lower version, technically you should target the min supported version of puppeteer (node v8.x should work fine, check this).
In the other side I couldn't Install the dev dependencies with node v10 (I used to have this before upgrading to v14), so the min supported version for the development machine is higher than the min version for production.

Originally posted by @iMrDJAi in #55 (comment)

@kaanyagci kaanyagci self-assigned this Jul 12, 2021
@kaanyagci kaanyagci added documentation Improvements or additions to documentation P1 Highest priorities labels Jul 12, 2021
@kaanyagci kaanyagci added this to P1 in npm module via automation Jul 12, 2021
@kaanyagci kaanyagci linked a pull request Jul 13, 2021 that will close this issue
npm module automation moved this from P1 to Done Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation P1 Highest priorities
Projects
Development

Successfully merging a pull request may close this issue.

1 participant