Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Attach an existing library of 3d models in read only mode #127

Closed
Samurai1201 opened this issue Feb 28, 2024 · 7 comments
Closed
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@Samurai1201
Copy link

I would really appreciate, if i could mount an existing library in read only mode (similar to how immich) and have it unaltered and instead write the new assets (like previews…) to another folder.
That way i would still be able to access and edit my existing library as I used to, but also gain the cool features of mmp.

Love the project, this is the feature that would make me use it immediately.
Thanks for creating this cool project

@EduardoOliveira EduardoOliveira self-assigned this Feb 29, 2024
@EduardoOliveira EduardoOliveira added enhancement New feature or request question Further information is requested labels Feb 29, 2024
@EduardoOliveira
Copy link
Contributor

Hi,
That's a big change in how MMP currently works, so I'll need to understand and discuss a bit the pros and cons.
So, the library folder would be read only, all the generated assets would be kept in the data folder, let's say.
Questions:

  • Would it be important to maintain the folder structure for the generated assets, or structuring them in a hash/uuid structure be feasible?
  • The external manipulation of the library folder wouldn't be reflected in real time on MMP, you would still have to issue total or partial rescans to discover the differences.

@Samurai1201
Copy link
Author

Thanks for the quick response :)
Storing the generated assets in hashed/uuid structure would be totally fine in my optinion, if it makes development easier.
Wouldn't it be possible to watch the folders using i.e. inotify and automatically run the rescan as needed?
But rescanning for myself would still be very feasable for me

@EduardoOliveira
Copy link
Contributor

Inotify would be a nice feature, but I'm unsure how functional it would be on top of docker mountpoints and weird NAS filesystems. Probably a pain to debug the multiple possible combinations

@EduardoOliveira
Copy link
Contributor

Something just hit me while developing this feature.
Using the UI features to create projects and the import features will write on the library folder, just not the generated assets.

@Samurai1201
Copy link
Author

I just asked myself, whether it would be possible to set the user (uid & guid), like in the linuxserver container images?
I cant find any option in the documentation...
Would this be easy to implement?

@EduardoOliveira
Copy link
Contributor

I've looked into the linuxserver implementations, there is some sort of runtime wrapper setting the uid/guid.
Please open a ticket in https://github.com/Maker-Management-Platform/agent/issues, so I don't lose track of that request.
Maybe someone offers to help implement that.

@Samurai1201
Copy link
Author

Sorry, just got around to creating the issue and noticed you had already put it in...
Thanks for your great work :)

@EduardoOliveira EduardoOliveira added this to the v1.3.0 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants