Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textsize/fontsize inconsistency #1422

Closed
KronosTheLate opened this issue Nov 1, 2021 · 1 comment
Closed

textsize/fontsize inconsistency #1422

KronosTheLate opened this issue Nov 1, 2021 · 1 comment
Projects

Comments

@KronosTheLate
Copy link
Contributor

When setting a theme, one uses the kwarg fontsize.
When creating a Label, one uses the kwarg textsize.

They each give the most sense in their current context, but I feel that it is the opposite of user-friendly to have these two things, which mean the same from the user-perspective, to have different kwargs.

Because changing a kwarg is breaking, I suggest that the two kwargs should give the same result in both contexts, aka be aliases of eachother.

@andrewwinters5000
Copy link

I think that this can be resolved as the textsize keyword argument has been removed in #2387

@ffreyer ffreyer closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Makie 1.0
Awaiting triage
Development

No branches or pull requests

3 participants