Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/combine-worker #5

Merged
merged 10 commits into from May 20, 2022
Merged

Feature/combine-worker #5

merged 10 commits into from May 20, 2022

Conversation

Maksimka101
Copy link
Owner

@Maksimka101 Maksimka101 commented May 18, 2022

Add CombineWorker and update Combine api

PR Checklist

  • Code is 100% covered.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • Changelog is updated.
  • Version is pumped

It is used to execute tasks in `CombineIsolate`s pull
It is like a thread pool which can be used to run functions
in isolate to do some long computation
@Maksimka101 Maksimka101 added the enhancement New feature or request label May 18, 2022
@Maksimka101 Maksimka101 marked this pull request as ready for review May 19, 2022 19:09
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #5 (db80573) into master (9fe7888) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master        #5    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           16        27    +11     
  Lines          161       319   +158     
==========================================
+ Hits           161       319   +158     
Impacted Files Coverage Δ
lib/src/isolate_context.dart 100.00% <ø> (ø)
lib/src/combine_info.dart 100.00% <100.00%> (ø)
...ib/src/combine_isolate/native_combine_isolate.dart 100.00% <100.00%> (ø)
lib/src/combine_isolate/web_combine_isolate.dart 100.00% <100.00%> (ø)
lib/src/combine_singleton.dart 100.00% <100.00%> (ø)
lib/src/combine_worker/combine_task_executor.dart 100.00% <100.00%> (ø)
lib/src/combine_worker/combine_worker_impl.dart 100.00% <100.00%> (ø)
lib/src/combine_worker/combine_worker_manager.dart 100.00% <100.00%> (ø)
...b/src/combine_worker/effective_worker_factory.dart 100.00% <100.00%> (ø)
lib/src/combine_worker/native_worker_manager.dart 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8348f6...db80573. Read the comment docs.

@Maksimka101 Maksimka101 merged commit 89aaf06 into master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants